fix: timing issue in S3 locker to prevent zombie locks (#812) #1928
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name: CI | |
| on: | |
| pull_request: | |
| push: | |
| branches: | |
| - master | |
| workflow_dispatch: | |
| permissions: | |
| contents: read | |
| concurrency: | |
| group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} | |
| cancel-in-progress: true | |
| jobs: | |
| test: | |
| name: Test / OS ${{ matrix.platform }} / Node ${{ matrix.node }} | |
| strategy: | |
| fail-fast: false | |
| matrix: | |
| platform: [ubuntu-24.04] | |
| node: ['20'] | |
| runs-on: ${{ matrix.platform }} | |
| timeout-minutes: 15 | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - uses: actions/cache@v4 | |
| with: | |
| path: ~/.npm | |
| key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }} | |
| restore-keys: | | |
| ${{ runner.os }}-node- | |
| - name: Set up Node | |
| uses: actions/setup-node@v4 | |
| with: | |
| node-version: ${{ matrix.node }} | |
| - name: Install dependencies | |
| run: | | |
| npm ci | |
| - name: Prettier checks | |
| run: | | |
| npm run lint | |
| - name: ESLint checks | |
| run: | | |
| npm run eslint:check | |
| - name: Builds successfully | |
| run: | | |
| npm run build | |
| - name: Tests pass | |
| run: | | |
| mkdir data && chmod -R 777 data && \ | |
| npm run test:coverage | |
| env: | |
| ANON_KEY: ${{ secrets.ANON_KEY }} | |
| SERVICE_KEY: ${{ secrets.SERVICE_KEY }} | |
| TENANT_ID: ${{ secrets.TENANT_ID }} | |
| REGION: ${{ secrets.REGION }} | |
| GLOBAL_S3_BUCKET: ${{ secrets.GLOBAL_S3_BUCKET }} | |
| PGRST_JWT_SECRET: ${{ secrets.PGRST_JWT_SECRET }} | |
| AUTHENTICATED_KEY: ${{ secrets.AUTHENTICATED_KEY }} | |
| DATABASE_URL: postgresql://postgres:postgres@127.0.0.1/postgres | |
| FILE_SIZE_LIMIT: '52428800' | |
| STORAGE_BACKEND: s3 | |
| MULTITENANT_DATABASE_URL: postgresql://postgres:postgres@127.0.0.1:5433/postgres | |
| ADMIN_API_KEYS: apikey | |
| ENABLE_IMAGE_TRANSFORMATION: true | |
| IMGPROXY_URL: http://127.0.0.1:50020 | |
| AWS_ACCESS_KEY_ID: supa-storage | |
| AWS_SECRET_ACCESS_KEY: secret1234 | |
| AWS_DEFAULT_REGION: ap-southeast-1 | |
| GLOBAL_S3_ENDPOINT: http://127.0.0.1:9000 | |
| GLOBAL_S3_PROTOCOL: http | |
| GLOBAL_S3_FORCE_PATH_STYLE: true | |
| DB_INSTALL_ROLES: true | |
| ENABLE_DEFAULT_METRICS: false | |
| PG_QUEUE_ENABLE: false | |
| MULTI_TENANT: false | |
| S3_PROTOCOL_ACCESS_KEY_ID: ${{ secrets.TENANT_ID }} | |
| S3_PROTOCOL_ACCESS_KEY_SECRET: ${{ secrets.SERVICE_KEY }} | |
| VECTOR_S3_BUCKETS: supa-test-local-dev | |
| VECTOR_ENABLED: true | |
| ICEBERG_ENABLED: true | |
| - name: Upload coverage results to Coveralls | |
| uses: coverallsapp/github-action@master | |
| with: | |
| github-token: ${{ secrets.GITHUB_TOKEN }} | |
| - name: Verify migration idempotency | |
| run: | | |
| pg_dump "$DATABASE_URL" \ | |
| --exclude-table-data=storage.migrations \ | |
| --restrict-key=test \ | |
| > before.sql | |
| npm run migration:test-idempotency | |
| pg_dump "$DATABASE_URL" \ | |
| --exclude-table-data=storage.migrations \ | |
| --restrict-key=test \ | |
| > after.sql | |
| diff before.sql after.sql || (echo 'Schema mismatch!'; exit 1) | |
| env: | |
| PGRST_JWT_SECRET: ${{ secrets.PGRST_JWT_SECRET }} | |
| DATABASE_URL: postgresql://postgres:postgres@127.0.0.1/postgres | |
| DB_INSTALL_ROLES: true | |
| ENABLE_DEFAULT_METRICS: false | |
| PG_QUEUE_ENABLE: false | |
| MULTI_TENANT: false | |
| - name: Ensure OrioleDB migration compatibility | |
| run: | | |
| npm run infra:restart:oriole | |
| env: | |
| PGRST_JWT_SECRET: ${{ secrets.PGRST_JWT_SECRET }} | |
| DATABASE_URL: postgresql://postgres:postgres@127.0.0.1/postgres | |
| DB_INSTALL_ROLES: true | |
| ENABLE_DEFAULT_METRICS: false | |
| PG_QUEUE_ENABLE: false | |
| MULTI_TENANT: false |