Merge pull request #16 from sumup-oss/add-validation-plan

Add validation during `plan` phase

Author: syndbg

.github/workflows/ci.yml

@@ -11,7 +11,7 @@ jobs:
     name: Test
     strategy:
       matrix:
-        golang: ["1.15"]
+        golang: ["1.16"]
         os: ["ubuntu-latest", "macos-latest"]
     runs-on: ${{ matrix.os }}
     steps:
@@ -32,7 +32,7 @@ jobs:
         uses: actions/[email protected]
 
       - name: Download golangci-lint
-        run: curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.23.8
+        run: curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.38.0
         if: "matrix.os == 'ubuntu-latest'"
 
       - name: Lint

.gitignore

@@ -11,3 +11,5 @@ dist/
 /terraform-provider-vaulted
 /terraform-provider-vaulted.exe
 /terraform-provider-vaulted.exe~
+sandbox/
+/mage_output_file.go

.go-version

@@ -1 +1 @@
-1.15.8
+1.16.2

.golangci.yml

@@ -26,8 +26,6 @@ linters-settings:
     # NOTE: Too-low cyclomatic complexity value
     # results into worse code design and readability.
     min-complexity: 25
-  maligned:
-    suggest-new: true
   dupl:
     threshold: 100
   goconst:
@@ -61,9 +59,24 @@ linters:
     - unparam
     # NOTE: It's a great linter, but gets in the way too often by not being customizable.
     - gochecknoglobals
-    # NOTE: False positives for values that are only used once in their appropriate places
-    # or `len(something) > 1` checks.
+    # NOTE: Full of false positives.
+    - interfacer
+    # NOTE: Function length is not an offense.
+    - funlen
+    # TODO: Fix false positives
     - gomnd
+    # NOTE: "Packages names should not use underscores" is not a good practice while mixed caps is also disallowed.
+    - stylecheck
+    # NOTE: Too verbose
+    - exhaustivestruct
+    # NOTE: Worse readability
+    - nlreturn
+    # NOTE: False-positives
+    - nestif
+    # NOTE: Deprecated
+    - maligned
+    # TODO: Enable and fix offences
+    - goerr113
 issues:
   exclude-rules:
     - text: "weak cryptographic primitive"

CHANGELOG.md

@@ -53,11 +53,23 @@ Change line format:
 
 ## Unreleased (master)
 
+### Added
+
+* Add validation during `plan` for `vaulted_vault_secret` ; Ref: https://github.com/sumup-oss/terraform-provider-vaulted/pull/16
+
+### Changed
+
+* Updated to Terraform Plugin SDK v2 ; Ref: https://github.com/sumup-oss/terraform-provider-vaulted/pull/16
+
+### Removed
+
+* Removed support for Terraform versions earlier than 0.11 and 0.11 itself ; Ref: https://github.com/sumup-oss/terraform-provider-vaulted/pull/16
+
 ## v0.4.3
 
 ### Changed
 
-* Build with Golang 1.15.x (1.15.8) ; Ref: https://github.com/sumup-oss/terraform-provider-vaulted/pull/
+* Build with Golang 1.15.x (1.15.8) ; Ref: https://github.com/sumup-oss/terraform-provider-vaulted/pull/9
 
 ## v0.4.2
 

go.mod

@@ -3,11 +3,12 @@ module github.com/sumup-oss/terraform-provider-vaulted
 go 1.13
 
 require (
-	github.com/hashicorp/terraform v0.12.28
+	github.com/hashicorp/terraform-plugin-sdk/v2 v2.4.3
 	github.com/hashicorp/vault v1.4.2
 	github.com/hashicorp/vault/api v1.0.5-0.20200317185738-82f498082f02
 	github.com/magefile/mage v1.8.0
-	github.com/stretchr/testify v1.5.1
+	github.com/palantir/stacktrace v0.0.0-20161112013806-78658fd2d177
+	github.com/stretchr/testify v1.6.1
 	github.com/sumup-oss/go-pkgs v0.0.0-20200519104547-45b130c89abb
 	github.com/sumup-oss/vaulted v0.2.1
 )