-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure vendor app's sqlalchemy code will not break when Airflow upgrades to sqlalchemy 2.0 #467
Comments
* via env var in both docker-compose files * via env var in test.yml CI config closes #467
per standup discussion, i also added this to the prod docker compose config, see #528. per the suggestion for the airflow project itself in the linked airflow ticket, i also added the env var to our CI test config. i spun up airflow locally with the new env var, and clicked around the UI, hitting the tabs in various DAGs, and clicking around in the vendor app. looking at my local log output, all the deprecation warnings seemed to be from airflow itself, and not from the vendor app:
i also ran the tests with the deprecation warning flag, and didn't see any SQLAlchemy 2.0 related deprecation warnings, though i did see some other SQLAlchemy related warnings, also entirely from airflow itself and not the vendor app:
|
Sqlalchemy 1.4 (current version) has 2.0 query styles and features available, and it doesn't look like we're using 1.4-style select statements, but to make sure we don't introduce anything that might break in an Airflow upgrade, consider:
SQLALCHEMY_WARN_20=1
todocker-compose.yaml
environment variables (not in prod). I think we'd see deprecation warnings in the DAG logs and/or docker logs.More docs: https://docs.sqlalchemy.org/en/20/changelog/migration_20.html#the-1-4-2-0-migration-path
The text was updated successfully, but these errors were encountered: