Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show the pencil icon next to the "Project" row #3103

Closed
andrewjbtw opened this issue Feb 11, 2022 · 2 comments · May be fixed by #3150
Closed

Show the pencil icon next to the "Project" row #3103

andrewjbtw opened this issue Feb 11, 2022 · 2 comments · May be fixed by #3150
Assignees
@jcoyne

Comments

@andrewjbtw
Copy link

The pencil icon is not showing in the "Project" row in the details table on the Argo show page. The "Project" field is essentially a tag and editable using the Tags interface, but for consistency we should show a pencil next to it as well.

Note that there is a Cocina complication around the Project tag, which is in the Cocina model. Non-project tags are not in the Cocina model. I don't think that should affect the pencil icon but there is a separate discussion about Project tags that we should return to. I thought we had a ticket about the Project tag (in DSA or Cocina) that but I'm having trouble finding it.
@peetucket peetucket changed the title (new Argo UI) Show the pencil icon next to the "Project" row Show the pencil icon next to the "Project" row Feb 18, 2022
@jcoyne jcoyne self-assigned this Feb 23, 2022
@jcoyne jcoyne mentioned this issue Feb 23, 2022
Open
@peetucket
Copy link
Member

Just pop up full tags editing interface when pencil icon clicked.

@andrewjbtw
Copy link
Author

I'm closing this in favor of opening a new issue later if we decide to change the current approach to editing tags. The current interface has now been in place for over a year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcoyne jcoyne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[HOLD] Edit project tag from the show page sul-dlss/argo
3 participants
@peetucket @jcoyne @andrewjbtw