-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Argo home page message or alert #924
Comments
This would be extremely useful not only for temporary alerts but for links to release notes and documentation of new functionality. We are making significant changes to Argo but have no way other than Slack or email to notify people. |
|
@astrid are you working on designs for how one sets/removes/changes these messages? |
I am not. Is there a ticket for that, or should I put it in here? |
I think putting it in here is fine. |
I could probably start working on this mocking out some UI. Unless there is some generalized library tool we can use for this purpose (or we want to build one, which I think is not likely), I think it makes sense to put these messages in a simple local db table in argo, with a simple CRUD interface for admins to edit what's there, and a rails partial to show any active messages? |
And Andrew approved. |
@astridu does that indicate we can remove the "feedback" and "Indexer Backlog: $x" items from the header? |
That just got cut off in the screen grab, but let me see if Indexer Backlog can be removed. |
We want to keep Feedback, but you can remove 'Indexer Backlog'. Thanks! |
@astridu currently the "Impersonate" button goes away if the user is impersonating another user and there is a message that shows who they are impersonating pops up. Can you say how the header bar should look while impersonating another user with the "Message alerts" addition? |
@astridu I'm not sure I understand. Should there be a submenu under that carret? Bootstrap 4, the UI toolkit we're using doesn't have support for nested dropdowns. https://getbootstrap.com/docs/4.5/components/dropdowns/ |
@astridu can you talk more about the behavior of the form?
|
@jcoyne Re- submenu. If we can't do the submenu, then behavior should be:
|
@jcoyne Answers to your questions: *What happens if they hit cancel, should it allow them to come back to their changes or should it reset them? *Does the calendar icon do anything? *Is there a reason we don't allow expired messages to be removed? *Should there be any confirmation dialogs (on save, cancel, or delete) ? *Do we need to accommodate smaller screens (tablets, phones)? *Have you chosen alternative text for icons for screen reader users? *Is there a reason you edit the date as MM/DD/YYYY and then display it as YYYY-MM-DD? *Should the date values have defaults? What should they be? *Are there any constraints we should be placing on the values? *What should it look like if they enter a very long message? |
@astridu sorry for all the questions. What about the time? Should this be at midnight pacific time? Do we need to indicate this anywhere? |
Oops, and what do we display when there are no messages? |
Yes, let's do midnight Pacific Time. I can add a note to the top of the page. "Primary messages will appear in a yellow box at the top of the homepage. Secondary messages will appear below the yellow primary message boxes in a bulleted list. Max 1,000 characters per message. Message will display and expire on the dates specified below at 12:00am PT." |
The top table is "active message alerts" but it should also display messages that are not active yet, right? |
Yes, just title it 'Message alerts'. Thanks! |
@astridu @andrewjbtw this is ready to be tested on argo-stage: |
Sorry, am I too late to see this? I didn't see it on stage, but the screenshot looks good. |
Can you make the text in the yellow box black so it's accessible? Thanks! |
This will go on stage this afternoon for review. But it's based on Blacklight 7 so that will need to go out for this to go out when it's all ready. |
@astridu I'm pretty sure this contrast ratio is accessible: https://contrast-ratio.com/#%23856404-on-%23fff3cd |
It's not AAA compliant, but I guess we're not aiming for that. In any case, can we change it to black because it looks better in black. |
Yes. |
is this done? If so, please close the ticket. If not - can it be attached to a PR (near bottom of PR in zenhub view) |
Yes, it's done. Thanks! |
The implementation for this is in #2045, it is still awaiting review by @andrewjbtw |
It's on hold because we determined that we need to sort out permissions to restrict this to a small number of editors #2045 (comment) |
Support the ability to put up a temporary message to users on the home page to alert them to current problems, upcoming outages, etc. Something an SDR admin could do by altering a resource without the need for deployment/restart or other developer/devOps involvement.
This has been discussed in the past as a need for a general facility for potentially any of our apps, particularly those where processing is involved -- Hydrus availability issues, ETDs, Mirador -- but also as a means to make announcements about, say, important new features.
The text was updated successfully, but these errors were encountered: