Skip to content
This repository has been archived by the owner on Aug 3, 2024. It is now read-only.

Re-deploy when user pushes or force pushes commits or re-opens #79

Open
williamdes opened this issue Jan 14, 2020 · 9 comments
Open

Re-deploy when user pushes or force pushes commits or re-opens #79

williamdes opened this issue Jan 14, 2020 · 9 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@williamdes
Copy link
Member

Reopened #4.
@ghost pushed 1 commit.

    64d0cd8 Fixes #15127: adding padding, fixed positioning to floating_menubar
@williamdes williamdes added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jan 14, 2020
@williamdes
Copy link
Member Author

The comment must be updated

@williamdes
Copy link
Member Author

@yashrajbothra @kartik1000 If you want to work on this you can
The basic policy of my repo is code and test, no need to run anything 😄

If the test passes then production will work

@williamdes
Copy link
Member Author

or #78

@yashrajbothra
Copy link

Hey @williamdes can you please guide how to install it and contribute in this repo. I would love to contribute👍

@williamdes
Copy link
Member Author

Hey @yashrajbothra
Do you have:

  • A database server installed ?
  • Docker ?
  • A test mailbox (not required)

But as I said, NodeJS is the only thing required.

  • clone
  • npm run test

Good to go !

You can code most of what you want without having docker, a database server is very recommended.
If you add tests you will be pretty sure it works fine

@williamdes
Copy link
Member Author

Also: copy .env.example to .env and fillwhat you can

One more thing, if some part of the code is too complicated for local devlopment you can add a configuration variable and split it.
SMTP_MODE=MAILBOX # MAILBOX OR FAKE_SMTP_SERVER is a good example of how I did that
But it can be improved a lot

@yashrajbothra
Copy link

Thank you @williamdes i will definetly try to install and contribute 👍

@yashrajbothra
Copy link

@williamdes How can test my changes?

@williamdes
Copy link
Member Author

@yashrajbothra you need to write unit tests to test each part of the code

Also be sure to run prettier

You can also start the project and send emails to your test email account but it is complicated

I will need to do some changes to help developers test changes

But this repo is mainly TDD :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Development

No branches or pull requests

2 participants