Add additional checks with warning/error messages for turbomachinery cases.

[bigfooted]

Is your feature request related to a problem? Please describe.

In a discussion on cfd-online we concluded that some warning/error messages will be helpful to guide users in setting up turbomachinery cases.

https://www.cfd-online.com/Forums/su2/258309-su2-compressor-turbomachinery-case.html

Conclusion: Warning/error messages for the 3 points below will be very useful:

1. Rotation axis must be positive z-axis using right hand rule
2. Flow must be in positive z-direction
3. periodic faces cant be split i.e. you must have only x1 pair of periodic faces per blade row

[joshkellyjak]

I think a refactor of the turbovertex structure would be very beneficial in the long run and will address points 1 & 2, maybe this would be better from a user perspective rather than error messgaes. If we're going to add something that determines the relative orientation of the boundaries, we might as well make it so the geometric preprocessing can use this information to build the turbovertex structure for machines with arbitary inflow/outflow orientation. Currently mixed-flow machines are not possible in develop, we could allow these types of machine with this. We will also probably slim down the code quite significantly and bring large section up to date with C++ 11 standards.

[Vaish-W]

Hi @bigfooted and @joshkellyjak ,

I would like to work on this issue as part of my contribution to SU2. I plan to implement the required checks and add appropriate warning/error messages for turbomachinery cases.
I’d be happy to collaborate or assist with any tasks related to this refactor. Please let me know if there’s a specific area where I could contribute.

Thank you!

[bigfooted]

Hi Vaishnavi, great to hear that you would like to work on improving the turbomachinery workflow. Are you currently working on a turbomachinery case that you can use as a testcase?

[joshkellyjak]

Good to hear! Could you join a developer meeting to discuss this further? @EvertBunschoten and I also discussed this yesterday, I think some coordination is in order

[Vaish-W]

Hi Vaishnavi, great to hear that you would like to work on improving the turbomachinery workflow. Are you currently working on a turbomachinery case that you can use as a testcase?

Yes, I have been working on simple turbomachinery case.

[Vaish-W]

Good to hear! Could you join a developer meeting to discuss this further? @EvertBunschoten and I also discussed this yesterday, I think some coordination is in order

Yeah sure, please let me know the details.

[joshkellyjak]

Good to hear! Could you join a developer meeting to discuss this further? @EvertBunschoten and I also discussed this yesterday, I think some coordination is in order

Yeah sure, please let me know the details.

The next meeting is EU time, the details can be found in the slack channel. If you need to find the link to join the channel you can find it at the top of https://su2code.github.io/