-
Notifications
You must be signed in to change notification settings - Fork 854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable user to change Mach number and Reynolds Number from Python Interface #2185
Comments
You would need to make some changes to the code to ensure that Mach number is always obtained from CConfig, currently we convert mach number to freestream velocity in some solvers and work with that instead. |
It looks more complicated than I initially assumed. Without Reynolds's number change, Mach's number change does not make sense. For me, at the moment, it is not worth investing some time in implementation. |
You’ll need to enhance the Python wrapper to allow setting these parameters before running simulations. This involves adding new methods to set Mach number and Reynolds number, ensuring they update the configuration, and testing the changes. My suggestions :
An interesting aspect is ensuring parameter precedence—if a config file is loaded, Python-set values must override file settings, which might require additional logic to handle configuration immutability. |
Hey! This issue seems interesting, and I would like to work on it. |
I want to introduce two new interfaces to change the Freestream Mach number and Reynolds Numbers from the Python interface.
As there are many parameters (mostly non/dimensional) affected by those two values I would like to get your insights on the viability and potential drawbacks of offering such an interface. Your thoughts on this matter would be greatly appreciated.
The text was updated successfully, but these errors were encountered: