diff --git a/src/Components/AppSettings/index.jsx b/src/Components/AppSettings/index.jsx
index e07715d6f..d20e736a7 100644
--- a/src/Components/AppSettings/index.jsx
+++ b/src/Components/AppSettings/index.jsx
@@ -2,6 +2,9 @@ import { useTranslation } from 'react-i18next';
import PropTypes from 'prop-types';
import React from 'react';
+import Divider from '@mui/material/Divider';
+import FormControl from '@mui/material/FormControl';
+
import Checkbox from '../Input/Checkbox';
import Overlay from '../Overlay';
@@ -29,14 +32,18 @@ function AppSettings({
switch(setting.type) {
case 'boolean': {
return (
-
+ <>
+
+
+
+ >
);
}
}
@@ -50,9 +57,12 @@ function AppSettings({
onClose={onClose}
open={open}
>
-
+
{settingElements}
-
+
);
diff --git a/src/Components/Flash/CommonSettings/__tests__/index.test.jsx b/src/Components/Flash/CommonSettings/__tests__/index.test.jsx
index b2a77185e..e1a0f26b5 100644
--- a/src/Components/Flash/CommonSettings/__tests__/index.test.jsx
+++ b/src/Components/Flash/CommonSettings/__tests__/index.test.jsx
@@ -291,13 +291,6 @@ describe('CommonSettings', () => {
userEvent.click(screen.getByRole(/checkbox/i));
expect(onSettingsUpdate).toHaveBeenCalled();
-
- fireEvent.change(screen.getByRole(/combobox/i), {
- taget: {
- value: 3,
- name: 'MOTOR_DIRECTION',
- },
- });
});
it('should allow updating with direct input', () => {
@@ -613,13 +606,6 @@ describe('CommonSettings', () => {
userEvent.click(screen.getByRole(/checkbox/i));
expect(onSettingsUpdate).toHaveBeenCalled();
-
- fireEvent.change(screen.getByRole(/combobox/i), {
- taget: {
- value: 3,
- name: 'MOTOR_DIRECTION',
- },
- });
});
it('should handle setting overrides', () => {
@@ -762,13 +748,6 @@ describe('CommonSettings', () => {
userEvent.click(screen.getByRole(/checkbox/i));
expect(onSettingsUpdate).toHaveBeenCalled();
-
- fireEvent.change(screen.getByRole(/combobox/i), {
- taget: {
- value: 3,
- name: 'MOTOR_DIRECTION',
- },
- });
});
it('should display warning when firmware is unsopported', () => {
diff --git a/src/Components/Flash/CommonSettings/index.jsx b/src/Components/Flash/CommonSettings/index.jsx
index 6e16a98f5..8f2007126 100644
--- a/src/Components/Flash/CommonSettings/index.jsx
+++ b/src/Components/Flash/CommonSettings/index.jsx
@@ -5,6 +5,9 @@ import React, {
useState,
} from 'react';
+import Divider from '@mui/material/Divider';
+import Stack from '@mui/material/Stack';
+
import {
getMasterSettings,
getMaster,
@@ -156,40 +159,73 @@ function CommonSettings({
switch (setting.type) {
case 'bool': {
return (
-
+ <>
+
+
+
+ >
);
}
case 'enum': {
const { options } = setting;
return (
-
+ <>
+
+
+
+ >
);
}
case 'number': {
if(directInput) {
return (
-
+
+
+
+ >
+ );
+ }
+
+ return (
+ <>
+
- );
- }
- return (
-
+
+ >
);
}
@@ -241,7 +260,9 @@ function CommonSettings({
- {settingElements}
+
+ {settingElements}
+
);
diff --git a/src/Components/Flash/Escs/Esc/__tests__/index.test.jsx b/src/Components/Flash/Escs/Esc/__tests__/index.test.jsx
index 227fb41cb..f4e499a2b 100644
--- a/src/Components/Flash/Escs/Esc/__tests__/index.test.jsx
+++ b/src/Components/Flash/Escs/Esc/__tests__/index.test.jsx
@@ -256,14 +256,6 @@ describe('Esc', () => {
expect(screen.queryByText(/invalid/i)).not.toBeInTheDocument();
userEvent.click(screen.getByRole(/checkbox/i));
-
- // Change select
- fireEvent.change(screen.getByRole(/combobox/i), {
- taget: {
- value: 3,
- name: 'MOTOR_DIRECTION',
- },
- });
});
it('should show custom settings and handle direct input', () => {
@@ -524,18 +516,10 @@ describe('Esc', () => {
/>
);
- expect(screen.getByLabelText('hints:COMMON_MOTOR_DIRECTION')).toBeInTheDocument();
+ expect(screen.getByText(/hints:COMMON_MOTOR_DIRECTION/i)).toBeInTheDocument();
expect(screen.getByText(/escMotorDirection/i)).toBeInTheDocument();
userEvent.click(screen.getByRole(/checkbox/i));
-
- // Change select
- fireEvent.change(screen.getByRole(/combobox/i), {
- taget: {
- value: 3,
- name: 'COMMON_MOTOR_DIRECTION',
- },
- });
});
it('should trigger firmware dump', () => {
diff --git a/src/Components/Input/Checkbox/index.jsx b/src/Components/Input/Checkbox/index.jsx
index 2297ca06a..fca89ba0d 100644
--- a/src/Components/Input/Checkbox/index.jsx
+++ b/src/Components/Input/Checkbox/index.jsx
@@ -2,6 +2,7 @@ import PropTypes from 'prop-types';
import React from 'react';
import FormControlLabel from '@mui/material/FormControlLabel';
+import FormHelperText from '@mui/material/FormHelperText';
import MuiCheckbox from '@mui/material/Checkbox';
import Info from '../Info';
@@ -17,7 +18,6 @@ function Checkbox({
}) {
const formattedLabel = (
}
label={formattedLabel}
/>
+
+
+ {hint}
+
);
}
diff --git a/src/Components/Input/Select/index.jsx b/src/Components/Input/Select/index.jsx
index 0fa5f8ac9..e856ea33e 100644
--- a/src/Components/Input/Select/index.jsx
+++ b/src/Components/Input/Select/index.jsx
@@ -1,9 +1,15 @@
import PropTypes from 'prop-types';
import React from 'react';
-import Info from '../Info';
+import FormControl from '@mui/material/FormControl';
+import FormHelperText from '@mui/material/FormHelperText';
+import InputLabel from '@mui/material/InputLabel';
+import MenuItem from '@mui/material/MenuItem';
+import MuiSelect from '@mui/material/Select';
-import './style.scss';
+//import Info from '../Info';
+
+//import './style.scss';
function Select({
name,
@@ -17,46 +23,52 @@ function Select({
}) {
function Select() {
const optionElements = options.map((option) => (
-
+
));
return (
-
+
);
}
return (
-
+
+
+
+ {hint}
+
+
);
}
diff --git a/src/Components/MainContent/style.scss b/src/Components/MainContent/style.scss
index 3f0bfbabc..d4bb53aa2 100644
--- a/src/Components/MainContent/style.scss
+++ b/src/Components/MainContent/style.scss
@@ -104,9 +104,9 @@
}
//.checkbox,
+ //.select,
.number,
- .number-text,
- .select {
+ .number-text {
margin-top: 7px;
margin-bottom: 7px;