Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant styling props in the next major version of xstyled #377

Open
quantizor opened this issue Jul 27, 2022 · 2 comments
Open

Comments

@quantizor
Copy link
Collaborator

There are a number of redundant props: bg vs backgroundColor, maxW vs maxWidth, maxH vs maxHeight

On the surface this doesn't seem like a big deal, but if you're making a component library using xstyled which has some base styling and allows overrides by the consumer, this could lead to issues if they don't match using the exact same prop.

We should choose to favor either the verbose or short versions and deprecate+remove the others to reduce complexity.

@jguddas
Copy link
Contributor

jguddas commented Jul 29, 2022

Can you share an example where overriding does not work?

Doing it like this for example works just fine.

@gregberge
Copy link
Collaborator

@probablyup I see what do you mean. It is a breaking change but I should consider it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants