PdfSharpCore.Utils.FontResolver code cleanup, refactor #268
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was working on the previous support for the local AppData fonts in Windows, I noticed that the code was a bit 'old'.
Things I changed:
static
constructor with a default constructor and make use of a static_isInitialized
field to check if another instance already has loaded the fontsDictionary<string, FontFamilyModel>
with aList<FontFamilyModel>
and make use of LINQ to lookup the fontsFontFileInfo
to its own file inPdfSharpCore.Utils
There were no tests, so I couldn't check if this breaks something. I did do a quick check with the font families from the issue in PR #267 and this worked like expected.