Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update mining-device-sv1 to tracing #1294

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

update mining-device-sv1 to tracing #1294

wants to merge 7 commits into from
+159 −158

Conversation

devworlds
Copy link

@devworlds devworlds commented Dec 12, 2024 •
edited
Loading

Hello, this is my first open-source pr, basically i follow what was asked.

  • update mining-device-sv1 from println! to info! using tracing following mining-device as example.

  • i don't update the eprintln! cause in the issue was mencioned only the println!

well, i hope this help.

the issue: #1286

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024 •
edited
Loading

🐰 Bencher Report

Branchissue/migrate-sv1-mining-device-to-tracing
Testbedsv1
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
estimated cycles
(Result Δ%)		Upper Boundary
estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
get_authorize📈 view plot
🚷 view threshold		8,421.00
(-0.44%)		8,725.50
(96.51%)		📈 view plot
🚷 view threshold		3,689.00
(-1.38%)		3,869.06
(95.35%)		📈 view plot
🚷 view threshold		5,156.00
(-1.64%)		5,450.46
(94.60%)		📈 view plot
🚷 view threshold		9.00
(+19.25%)		14.62
(61.54%)		📈 view plot
🚷 view threshold		92.00
(+1.30%)		95.74
(96.10%)
get_submit📈 view plot
🚷 view threshold		95,205.00
(-0.21%)		95,848.92
(99.33%)		📈 view plot
🚷 view threshold		59,346.00
(-0.16%)		59,712.28
(99.39%)		📈 view plot
🚷 view threshold		85,220.00
(-0.18%)		85,815.97
(99.31%)		📈 view plot
🚷 view threshold		51.00
(+15.13%)		60.18
(84.74%)		📈 view plot
🚷 view threshold		278.00
(-0.78%)		290.11
(95.82%)
get_subscribe📈 view plot
🚷 view threshold		7,906.00
(-1.32%)		8,281.59
(95.46%)		📈 view plot
🚷 view threshold		2,765.00
(-2.18%)		2,949.59
(93.74%)		📈 view plot
🚷 view threshold		3,846.00
(-2.58%)		4,144.92
(92.79%)		📈 view plot
🚷 view threshold		14.00
(+18.05%)		19.98
(70.07%)		📈 view plot
🚷 view threshold		114.00
(-0.36%)		118.58
(96.14%)
serialize_authorize📈 view plot
🚷 view threshold		12,150.00
(-1.01%)		12,565.79
(96.69%)		📈 view plot
🚷 view threshold		5,266.00
(-0.88%)		5,435.12
(96.89%)		📈 view plot
🚷 view threshold		7,325.00
(-1.09%)		7,606.68
(96.30%)		📈 view plot
🚷 view threshold		13.00
(+37.98%)		17.58
(73.95%)		📈 view plot
🚷 view threshold		136.00
(-1.27%)		142.60
(95.37%)
serialize_deserialize_authorize📈 view plot
🚷 view threshold		24,640.00
(-0.26%)		25,205.77
(97.76%)		📈 view plot
🚷 view threshold		9,838.00
(-0.42%)		10,037.49
(98.01%)		📈 view plot
🚷 view threshold		13,875.00
(-0.51%)		14,201.50
(97.70%)		📈 view plot
🚷 view threshold		39.00
(+11.58%)		44.95
(86.77%)		📈 view plot
🚷 view threshold		302.00
(-0.14%)		314.21
(96.11%)
serialize_deserialize_handle_authorize📈 view plot
🚷 view threshold		30,156.00
(-0.56%)		30,751.04
(98.06%)		📈 view plot
🚷 view threshold		12,015.00
(-0.46%)		12,207.98
(98.42%)		📈 view plot
🚷 view threshold		16,996.00
(-0.55%)		17,311.81
(98.18%)		📈 view plot
🚷 view threshold		63.00
(+13.32%)		67.48
(93.37%)		📈 view plot
🚷 view threshold		367.00
(-0.86%)		380.77
(96.38%)
serialize_deserialize_handle_submit📈 view plot
🚷 view threshold		126,257.00
(-0.17%)		126,908.19
(99.49%)		📈 view plot
🚷 view threshold		73,200.00
(-0.10%)		73,534.05
(99.55%)		📈 view plot
🚷 view threshold		104,912.00
(-0.13%)		105,486.58
(99.46%)		📈 view plot
🚷 view threshold		111.00
(+4.79%)		125.93
(88.14%)		📈 view plot
🚷 view threshold		594.00
(-0.49%)		607.19
(97.83%)
serialize_deserialize_handle_subscribe📈 view plot
🚷 view threshold		27,756.00
(-0.42%)		28,535.54
(97.27%)		📈 view plot
🚷 view threshold		9,584.00
(-0.61%)		9,763.82
(98.16%)		📈 view plot
🚷 view threshold		13,531.00
(-0.77%)		13,832.47
(97.82%)		📈 view plot
🚷 view threshold		73.00
(+14.79%)		76.20
(95.80%)		📈 view plot
🚷 view threshold		396.00
(-0.43%)		414.39
(95.56%)
serialize_deserialize_submit📈 view plot
🚷 view threshold		115,161.00
(-0.08%)		115,780.89
(99.46%)		📈 view plot
🚷 view threshold		68,060.00
(-0.05%)		68,414.98
(99.48%)		📈 view plot
🚷 view threshold		97,646.00
(-0.07%)		98,266.84
(99.37%)		📈 view plot
🚷 view threshold		73.00
(+15.57%)		81.41
(89.67%)		📈 view plot
🚷 view threshold		490.00
(-0.42%)		500.74
(97.86%)
serialize_deserialize_subscribe📈 view plot
🚷 view threshold		23,184.00
(-0.47%)		23,923.73
(96.91%)		📈 view plot
🚷 view threshold		8,143.00
(-0.67%)		8,319.73
(97.88%)		📈 view plot
🚷 view threshold		11,449.00
(-0.83%)		11,739.51
(97.53%)		📈 view plot
🚷 view threshold		44.00
(+16.92%)		46.87
(93.87%)		📈 view plot
🚷 view threshold		329.00
(-0.39%)		345.56
(95.21%)
serialize_submit📈 view plot
🚷 view threshold		99,594.00
(-0.23%)		100,284.34
(99.31%)		📈 view plot
🚷 view threshold		61,408.00
(-0.13%)		61,741.12
(99.46%)		📈 view plot
🚷 view threshold		88,079.00
(-0.16%)		88,646.02
(99.36%)		📈 view plot
🚷 view threshold		56.00
(+19.89%)		64.17
(87.27%)		📈 view plot
🚷 view threshold		321.00
(-1.21%)		335.45
(95.69%)
serialize_subscribe📈 view plot
🚷 view threshold		11,351.00
(-0.48%)		11,674.63
(97.23%)		📈 view plot
🚷 view threshold		4,118.00
(-1.36%)		4,291.43
(95.96%)		📈 view plot
🚷 view threshold		5,706.00
(-1.71%)		5,997.60
(95.14%)		📈 view plot
🚷 view threshold		16.00
(+23.08%)		21.66
(73.87%)		📈 view plot
🚷 view threshold		159.00
(+0.54%)		163.76
(97.10%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024 •
edited
Loading

🐰 Bencher Report

Branchissue/migrate-sv1-mining-device-to-tracing
Testbedsv2
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		45.17
(+1.29%)		46.87
(96.37%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		72.61
(-4.83%)		94.58
(76.77%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		14.73
(+0.47%)		14.79
(99.60%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		275.09
(+3.14%)		300.85
(91.44%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		588.96
(-4.34%)		677.15
(86.98%)
client_sv2_open_channel📈 view plot
🚷 view threshold		163.10
(+0.84%)		188.24
(86.64%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		282.19
(-0.68%)		311.21
(90.68%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		386.43
(+0.70%)		412.00
(93.79%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		157.28
(-1.91%)		171.79
(91.55%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		446.71
(-4.91%)		548.33
(81.47%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		1,057.40
(+5.84%)		1,102.65
(95.90%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024 •
edited
Loading

🐰 Bencher Report

Branchissue/migrate-sv1-mining-device-to-tracing
Testbedsv1
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client-submit-serialize📈 view plot
🚷 view threshold		6,625.70
(-0.26%)		7,117.12
(93.10%)
client-submit-serialize-deserialize📈 view plot
🚷 view threshold		7,462.60
(-0.73%)		8,115.64
(91.95%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle📈 view plot
🚷 view threshold		8,110.90
(-0.07%)		8,609.92
(94.20%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle📈 view plot
🚷 view threshold		858.29
(-0.81%)		928.17
(92.47%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize📈 view plot
🚷 view threshold		665.42
(-0.89%)		704.07
(94.51%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize📈 view plot
🚷 view threshold		245.65
(-1.11%)		270.43
(90.84%)
client-sv1-get-authorize/client-sv1-get-authorize📈 view plot
🚷 view threshold		155.94
(-0.72%)		164.73
(94.67%)
client-sv1-get-submit📈 view plot
🚷 view threshold		6,387.20
(-0.77%)		7,102.73
(89.93%)
client-sv1-get-subscribe/client-sv1-get-subscribe📈 view plot
🚷 view threshold		281.77
(+0.54%)		304.17
(92.64%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle📈 view plot
🚷 view threshold		741.65
(+1.78%)		783.04
(94.71%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize📈 view plot
🚷 view threshold		593.43
(+0.53%)		633.99
(93.60%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize📈 view plot
🚷 view threshold		208.18
(+1.03%)		218.14
(95.44%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024 •
edited
Loading

🐰 Bencher Report

Branchissue/migrate-sv1-mining-device-to-tracing
Testbedsv2

🚨 1 Alert

BenchmarkMeasure
Units		ViewBenchmark Result
(Result Δ%)		Upper Boundary
(Limit %)
client_sv2_handle_message_miningEstimated Cycles
estimated cycles		📈 plot
🚨 alert (🔕)
🚷 threshold		8,352.00
(+1.70%)		8,350.37
(100.02%)
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
estimated cycles
(Result Δ%)		Upper Boundary
estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		2,121.00
(+0.88%)		2,215.46
(95.74%)		📈 view plot
🚷 view threshold		473.00
(-0.08%)		488.79
(96.77%)		📈 view plot
🚷 view threshold		736.00
(+0.01%)		757.51
(97.16%)		📈 view plot
🚷 view threshold		4.00
(-22.19%)		13.14
(30.43%)		📈 view plot
🚷 view threshold		39.00
(+1.79%)		41.36
(94.29%)
client_sv2_handle_message_mining📈 view plot
🚨 view alert (🔕)
🚷 view threshold		8,352.00
(+1.70%)		8,350.37
(100.02%)		📈 view plot
🚷 view threshold		2,137.00
(-0.03%)		2,143.08
(99.72%)		📈 view plot
🚷 view threshold		3,152.00
(-0.26%)		3,171.25
(99.39%)		📈 view plot
🚷 view threshold		39.00
(+10.22%)		41.41
(94.19%)		📈 view plot
🚷 view threshold		143.00
(+2.66%)		143.09
(99.94%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		6,387.00
(+1.52%)		6,428.16
(99.36%)		📈 view plot
🚷 view threshold		1,750.00
(-0.05%)		1,767.12
(99.03%)		📈 view plot
🚷 view threshold		2,547.00
(-0.23%)		2,575.84
(98.88%)		📈 view plot
🚷 view threshold		19.00
(+11.87%)		24.28
(78.26%)		📈 view plot
🚷 view threshold		107.00
(+2.50%)		108.18
(98.91%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		14,820.00
(+0.64%)		14,943.00
(99.18%)		📈 view plot
🚷 view threshold		4,694.00
(-0.02%)		4,711.12
(99.64%)		📈 view plot
🚷 view threshold		6,745.00
(-0.19%)		6,784.36
(99.42%)		📈 view plot
🚷 view threshold		54.00
(+22.51%)		57.10
(94.56%)		📈 view plot
🚷 view threshold		223.00
(+0.74%)		226.90
(98.28%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		27,796.00
(+0.86%)		27,923.27
(99.54%)		📈 view plot
🚷 view threshold		10,645.00
(+0.48%)		10,673.65
(99.73%)		📈 view plot
🚷 view threshold		15,501.00
(+0.53%)		15,550.84
(99.68%)		📈 view plot
🚷 view threshold		93.00
(+13.21%)		93.94
(99.00%)		📈 view plot
🚷 view threshold		338.00
(+0.86%)		341.84
(98.88%)
client_sv2_open_channel📈 view plot
🚷 view threshold		4,481.00
(+2.12%)		4,560.15
(98.26%)		📈 view plot
🚷 view threshold		1,461.00
(-0.03%)		1,476.79
(98.93%)		📈 view plot
🚷 view threshold		2,156.00
(-0.21%)		2,183.53
(98.74%)		📈 view plot
🚷 view threshold		10.00
(+18.74%)		15.34
(65.19%)		📈 view plot
🚷 view threshold		65.00
(+4.10%)		67.23
(96.68%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		14,108.00
(+0.58%)		14,263.35
(98.91%)		📈 view plot
🚷 view threshold		5,064.00
(-0.01%)		5,079.79
(99.69%)		📈 view plot
🚷 view threshold		7,318.00
(-0.12%)		7,350.88
(99.55%)		📈 view plot
🚷 view threshold		42.00
(+18.73%)		44.93
(93.47%)		📈 view plot
🚷 view threshold		188.00
(+0.87%)		193.25
(97.28%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		22,820.00
(+0.66%)		22,944.99
(99.46%)		📈 view plot
🚷 view threshold		8,040.00
(+0.15%)		8,063.52
(99.71%)		📈 view plot
🚷 view threshold		11,690.00
(+0.10%)		11,731.30
(99.65%)		📈 view plot
🚷 view threshold		84.00
(+12.39%)		86.10
(97.56%)		📈 view plot
🚷 view threshold		306.00
(+0.87%)		310.41
(98.58%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		4,711.00
(+0.53%)		4,782.05
(98.51%)		📈 view plot
🚷 view threshold		1,502.00
(-0.02%)		1,517.79
(98.96%)		📈 view plot
🚷 view threshold		2,276.00
(-0.10%)		2,299.31
(98.99%)		📈 view plot
🚷 view threshold		11.00
(+13.92%)		16.52
(66.60%)		📈 view plot
🚷 view threshold		68.00
(+0.87%)		69.99
(97.16%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		16,244.00
(+0.56%)		16,366.36
(99.25%)		📈 view plot
🚷 view threshold		5,963.00
(-0.01%)		5,978.79
(99.74%)		📈 view plot
🚷 view threshold		8,654.00
(-0.12%)		8,690.83
(99.58%)		📈 view plot
🚷 view threshold		48.00
(+20.45%)		53.12
(90.37%)		📈 view plot
🚷 view threshold		210.00
(+0.82%)		213.77
(98.24%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		35,710.00
(+0.40%)		35,837.48
(99.64%)		📈 view plot
🚷 view threshold		14,888.00
(+0.19%)		14,911.25
(99.84%)		📈 view plot
🚷 view threshold		21,870.00
(+0.18%)		21,917.83
(99.78%)		📈 view plot
🚷 view threshold		108.00
(+16.95%)		112.40
(96.08%)		📈 view plot
🚷 view threshold		380.00
(+0.20%)		384.84
(98.74%)
🐰 View full continuous benchmarking report in Bencher

@codecov Codecov
Copy link

codecov bot commented Dec 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 19.36%. Comparing base (22da418) to head (8d9ed93).

Files with missing lines Patch % Lines
...d-client/src/lib/job_declarator/message_handler.rs 0.00% 1 Missing ⚠️
roles/test-utils/mining-device-sv1/src/miner.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1294      +/-   ##
==========================================
+ Coverage   19.30%   19.36%   +0.06%     
==========================================
  Files         164      164              
  Lines       10849    10815      -34     
==========================================
  Hits         2094     2094              
+ Misses       8755     8721      -34
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_serde_sv2-coverage 3.65% <ø> (ø)
binary_sv2-coverage 5.48% <ø> (ø)
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 25.02% <ø> (ø)
codec_sv2-coverage 0.01% <ø> (ø)
common_messages_sv2-coverage 0.13% <ø> (ø)
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.29% <ø> (ø)
jd_client-coverage 0.00% <0.00%> (ø)
jd_server-coverage 8.82% <ø> (+1.03%) ⬆️
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 2.39% <ø> (ø)
mining-coverage 2.49% <ø> (-0.02%) ⬇️
mining_device-coverage 0.00% <ø> (ø)
mining_proxy_sv2-coverage 0.80% <ø> (+0.09%) ⬆️
noise_sv2-coverage 4.35% <ø> (ø)
pool_sv2-coverage 1.56% <ø> (+0.17%) ⬆️
protocols 24.72% <ø> (ø)
roles 6.62% <0.00%> (+0.06%) ⬆️
roles_logic_sv2-coverage 8.08% <ø> (ø)
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage 10.04% <ø> (+0.43%) ⬆️
utils 25.13% <ø> (ø)
v1-coverage 2.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@devworlds