Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SRI should not assume that coinbase scriptSig prefix contains only BIP34 #1460

Open
plebhash opened this issue Feb 6, 2025 · 0 comments · May be fixed by #1461
Open

SRI should not assume that coinbase scriptSig prefix contains only BIP34 #1460

plebhash opened this issue Feb 6, 2025 · 0 comments · May be fixed by #1461
Labels
refactor Implies refactoring code roles-logic-sv2

Comments

@plebhash
Copy link
Collaborator

plebhash commented Feb 6, 2025

in this discussion #1256 (comment) it was noted that SRI (more specifically job_creator module of roles_logic_sv2) seems to be based on the assumption that the coinbase scriptSig prefix contains only BIP34

while this is true now, that's not a safe assumption

to quote @Sjors :

... In any case, one day Bitcoin Core might add more stuff to the scriptSig after the BIP34 commitment. Or it might stop adding the useless 0 for heights > 15. So it's best not to make any assumptions here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Implies refactoring code roles-logic-sv2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove assumption that coinbase scriptSig prefix contains only BIP34 plebhash/stratum
1 participant
@plebhash