Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate translation-proxy-broke-pool MG to Integration Test #1415

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Migrate translation-proxy-broke-pool MG to Integration Test #1415

wants to merge 2 commits into from
+48 −129

Conversation

plebhash
Copy link
Collaborator

@plebhash plebhash commented Jan 29, 2025 •
edited
Loading

close #1414

note: ideally, Sniffer should have a primitive to assert a connection was broken... but that is currently blocked by #1389 so we bypassed that by asserting that a port is free inside the test

@plebhash plebhash force-pushed the migrate-mg-tproxy-bad-extranonce branch from e0adaa3 to 15a257b Compare January 29, 2025 16:33
@plebhash plebhash mentioned this pull request Jan 29, 2025
Open
@plebhash plebhash force-pushed the migrate-mg-tproxy-bad-extranonce branch from 15a257b to 05bbfa5 Compare January 29, 2025 16:39
@codecov Codecov
Copy link

codecov bot commented Jan 29, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.08%. Comparing base (c605e0d) to head (05bbfa5).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1415   +/-   ##
=======================================
  Coverage   19.08%   19.08%           
=======================================
  Files         166      166           
  Lines       11066    11066           
=======================================
  Hits         2112     2112           
  Misses       8954     8954
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_serde_sv2-coverage 3.55% <ø> (ø)
binary_sv2-coverage 5.34% <ø> (ø)
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 25.02% <ø> (ø)
codec_sv2-coverage 0.01% <ø> (ø)
common_messages_sv2-coverage 0.13% <ø> (ø)
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.28% <ø> (ø)
jd_client-coverage 0.00% <ø> (ø)
jd_server-coverage 7.79% <ø> (ø)
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 2.39% <ø> (ø)
mining-coverage 2.44% <ø> (+0.01%) ⬆️
mining_device-coverage 0.00% <ø> (ø)
mining_proxy_sv2-coverage 0.70% <ø> (ø)
noise_sv2-coverage 4.44% <ø> (ø)
pool_sv2-coverage 2.04% <ø> (ø)
protocols 24.57% <ø> (ø)
roles 6.54% <ø> (ø)
roles_logic_sv2-coverage 7.93% <ø> (ø)
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage 9.60% <ø> (ø)
utils 25.13% <ø> (?)
v1-coverage 2.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@plebhash plebhash requested a review from jbesraa January 29, 2025 17:07
jbesraa
jbesraa approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@jbesraa jbesraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbesraa jbesraa jbesraa approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ci/cd CI/CD integration-tests message-generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI migration: translation-proxy-broke-pool MG to Integration Test
2 participants
@plebhash @jbesraa