Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguous NewMiningJob stratum-message format #1395

Open
jakubtrnka opened this issue Jan 24, 2025 · 1 comment
Open

Ambiguous NewMiningJob stratum-message format #1395

jakubtrnka opened this issue Jan 24, 2025 · 1 comment

Comments

@jakubtrnka
Copy link
Contributor

NewMiningJob is defined here:
https://github.com/stratum-mining/sv2-spec/blob/main/05-Mining-Protocol.md#5315-newminingjob-server---client

the merkle-root is supposed to be 32-bytes array.
It is, however, declared as B32, which can easily be mistaken for a generic byte array Bytes0_32 which has a one-byte length prefix

"B32" is not defined in the section of types.
https://github.com/stratum-mining/sv2-spec/blob/main/03-Protocol-Overview.md#31-data-types-mapping

It's a question how to exactly reword the specification - Bytes type of length 32 or the U256? But in any case B0_32 is incorrect and is the reason why
SRI is not compatible with Braiins SV2 miners

@Sjors
Copy link
Collaborator

Sjors commented Jan 29, 2025

Nice catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants