Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider changing roles behavior on start from blocking to non blocking #1356

Open
jbesraa opened this issue Jan 16, 2025 · 0 comments
Open

Consider changing roles behavior on start from blocking to non blocking #1356

jbesraa opened this issue Jan 16, 2025 · 0 comments
Labels
refactor Implies refactoring code roles Pertains to all roles

Comments

@jbesraa
Copy link
Contributor

jbesraa commented Jan 16, 2025

Currently all roles start a loop which blocks the start function from returning early. Ideally the start function would run any blocking code in a separate thread.

Example from jd-client role: https://github.com/stratum-mining/stratum/blob/main/roles/jd-client/src/lib/mod.rs#L92
@plebhash plebhash added roles Pertains to all roles refactor Implies refactoring code labels Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Implies refactoring code roles Pertains to all roles
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbesraa @plebhash