Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Coverage Percentage Due to Inclusion of Workspace Dependencies #1209

Open
Shourya742 opened this issue Oct 14, 2024 · 0 comments
Open

Comments

@Shourya742
Copy link
Contributor

We are currently isolating the coverage of individual workspace crates using specific flags. While this successfully identifies the coverage for the intended crate, the percentage it calculates is skewed. It bases the coverage on the lines covered in the crate against the total lines from all the crate dependencies within the workspace. This results in an incorrect coverage percentage.

For example, the actual coverage for the noise-sv2 crate is 64.31%, but because it includes all the lines from the workspace dependencies, the reported coverage drops to around 4.xx%.

Noise-sv2 crate Coverage Noise-sv2 crate Coverage

Check the lines covered and the total lines considered: 277/4664 = 0.486.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant