Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: subprotocols crates #1202

Open
GitGab19 opened this issue Oct 11, 2024 · 9 comments
Open

Refactor: subprotocols crates #1202

GitGab19 opened this issue Oct 11, 2024 · 9 comments
Labels
protocols Lowest level protocol logic refactor Implies refactoring code

Comments

@GitGab19
Copy link
Collaborator

This task is an outcome of the protocols Rust docs issues tracked in #845.

While documenting protocols::v2::subprotocols in #1201, areas of potential code debt were identified. This issue servers as a place to list out these items to then be addressed in an organized manner. The initial Rust documentation effort was an immediate action, while a refactoring (which implies breaking API changes) is not so urgent priority, so for now we should leave this in the backlog for an appropriate moment in the future.

Identified Potential Code Debt

TODO

@GitGab19 GitGab19 added refactor Implies refactoring code protocols Lowest level protocol logic labels Oct 11, 2024
@Shourya742
Copy link
Contributor

Shourya742 commented Dec 2, 2024

common_message_sv2: #1242 (comment)

@Shourya742
Copy link
Contributor

common_message_sv2: #1242 (comment)

@Shourya742
Copy link
Contributor

common_message_sv2: #1242 (comment)

@Shourya742
Copy link
Contributor

template-distribution: #1257 (comment)

@Shourya742
Copy link
Contributor

template-distribution: #1257 (comment)

@Shourya742
Copy link
Contributor

template-distribution: #1257 (comment)

@Shourya742
Copy link
Contributor

template-distribution: #1257 (comment)

@jbesraa
Copy link
Contributor

jbesraa commented Dec 3, 2024

One of the key things I think we are missing in the subprotocols is how to actually use them.

For example, there is no explanation how to connect to a pool and open SV2 compatible channel. Or simpler, how do I connect to a template provider.

For us this stuff is intuitive and we have roles crates as reference but I actually think the main reference should be in the subprotocols crates.

@plebhash
Copy link
Collaborator

plebhash commented Dec 5, 2024

One of the key things I think we are missing in the subprotocols is how to actually use them.

For example, there is no explanation how to connect to a pool and open SV2 compatible channel. Or simpler, how do I connect to a template provider.

For us this stuff is intuitive and we have roles crates as reference but I actually think the main reference should be in the subprotocols crates.

I see your point, but is that technical debt or lack of docs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocols Lowest level protocol logic refactor Implies refactoring code
Projects
None yet
Development

No branches or pull requests

4 participants