Migrate Sv2 Roles to use rust-bitcoincore-rpc

[average-gary]

https://github.com/rust-bitcoin/rust-bitcoincore-rpc

#1095 (comment)
#1095 (review)

There's probably a checklist to be made here for follow on issues/PRs.

[Fi3]

we removed that dependency why do you want re add it? @lorbax

[jbesraa]

we removed that dependency why do you want re add it? @lorbax

why was it removed?

@marathon-gary do you mind please explaining why you would prefer rust-bitcoincore-rpc over mini-rpc ?

[average-gary]

we removed that dependency why do you want re add it?

I was unaware of this history, I'll dig through issues/PRs to find the reasoning.

do you mind please explaining why you would prefer rust-bitcoincore-rpc over mini-rpc ?

Reducing the amount of code that needs to be maintained is the first thing that comes to mind.
Aside from that, I don't have a technical argument, as I assume mini-rpc works fine.

[average-gary]

#761 (comment)
Found this reasoning but didn't dig into what the import problem is. Would be fine to leave as is since it works.

[Fi3]

if I remeber correctly was to have somthing with an async api but not sure maybe @lorbax remeber better.
Btw that remove a dependecy that per se is not bad

[lorbax]

json-rpc uses serde for serializing and deserializing. The way it is imported is non compatible with the way it is imported in the libraries. To fix this error requires likely much more work than writing it ex novo.

[jbesraa]

Is there a documentation of the actual error?

[lorbax]

Is there a documentation of the actual error?

no, but it is easy to try reproduce it, you have to use bitcoincore-rpc and as I remember you get an error by just importing it.