feat: cargo clippy warning solved

devworlds · plebhash · commit 060060225775 · 2024-12-14T07:18:00.000-03:00
diff --git a/roles/jd-client/src/lib/error.rs b/roles/jd-client/src/lib/error.rs
@@ -61,7 +61,7 @@ pub enum Error<'a> {
     Infallible(std::convert::Infallible),
 }
 
-impl<'a> fmt::Display for Error<'a> {
+impl fmt::Display for Error<'_> {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         use Error::*;
         match self {
@@ -86,55 +86,55 @@ impl<'a> fmt::Display for Error<'a> {
     }
 }
 
-impl<'a> From<binary_sv2::Error> for Error<'a> {
+impl From<binary_sv2::Error> for Error<'_> {
     fn from(e: binary_sv2::Error) -> Self {
         Error::BinarySv2(e)
     }
 }
 
-impl<'a> From<codec_sv2::noise_sv2::Error> for Error<'a> {
+impl From<codec_sv2::noise_sv2::Error> for Error<'_> {
     fn from(e: codec_sv2::noise_sv2::Error) -> Self {
         Error::CodecNoise(e)
     }
 }
 
-impl<'a> From<framing_sv2::Error> for Error<'a> {
+impl From<framing_sv2::Error> for Error<'_> {
     fn from(e: framing_sv2::Error) -> Self {
         Error::FramingSv2(e)
     }
 }
 
-impl<'a> From<std::io::Error> for Error<'a> {
+impl From<std::io::Error> for Error<'_> {
     fn from(e: std::io::Error) -> Self {
         Error::Io(e)
     }
 }
 
-impl<'a> From<std::num::ParseIntError> for Error<'a> {
+impl From<std::num::ParseIntError> for Error<'_> {
     fn from(e: std::num::ParseIntError) -> Self {
         Error::ParseInt(e)
     }
 }
 
-impl<'a> From<roles_logic_sv2::errors::Error> for Error<'a> {
+impl From<roles_logic_sv2::errors::Error> for Error<'_> {
     fn from(e: roles_logic_sv2::errors::Error) -> Self {
         Error::RolesSv2Logic(e)
     }
 }
 
-impl<'a> From<ConfigError> for Error<'a> {
+impl From<ConfigError> for Error<'_> {
     fn from(e: ConfigError) -> Self {
         Error::BadConfigDeserialize(e)
     }
 }
 
-impl<'a> From<async_channel::RecvError> for Error<'a> {
+impl From<async_channel::RecvError> for Error<'_> {
     fn from(e: async_channel::RecvError) -> Self {
         Error::ChannelErrorReceiver(e)
     }
 }
 
-impl<'a> From<tokio::sync::broadcast::error::RecvError> for Error<'a> {
+impl From<tokio::sync::broadcast::error::RecvError> for Error<'_> {
     fn from(e: tokio::sync::broadcast::error::RecvError) -> Self {
         Error::TokioChannelErrorRecv(e)
     }
@@ -176,7 +176,7 @@ impl<'a> From<async_channel::SendError<roles_logic_sv2::mining_sv2::SetNewPrevHa
     }
 }
 
-impl<'a> From<async_channel::SendError<(ExtendedExtranonce, u32)>> for Error<'a> {
+impl From<async_channel::SendError<(ExtendedExtranonce, u32)>> for Error<'_> {
     fn from(e: async_channel::SendError<(ExtendedExtranonce, u32)>) -> Self {
         Error::ChannelErrorSender(ChannelSendError::Extranonce(e))
     }
@@ -212,13 +212,13 @@ impl<'a>
     }
 }
 
-impl<'a> From<ParseLengthError> for Error<'a> {
+impl From<ParseLengthError> for Error<'_> {
     fn from(e: ParseLengthError) -> Self {
         Error::Uint256Conversion(e)
     }
 }
 
-impl<'a> From<std::convert::Infallible> for Error<'a> {
+impl From<std::convert::Infallible> for Error<'_> {
     fn from(e: std::convert::Infallible) -> Self {
         Error::Infallible(e)
     }
diff --git a/roles/jd-client/src/lib/job_declarator/message_handler.rs b/roles/jd-client/src/lib/job_declarator/message_handler.rs
@@ -67,7 +67,7 @@ impl ParseServerJobDeclarationMessages for JobDeclarator {
                     None
                 }
             })
-            .ok_or_else(|| Error::UnknownRequestId(message.request_id))?;
+            .ok_or(Error::UnknownRequestId(message.request_id))?;
 
         let unknown_tx_position_list: Vec<u16> = message.unknown_tx_position_list.into_inner();
         let missing_transactions: Vec<binary_sv2::B016M> = unknown_tx_position_list
diff --git a/roles/translator/src/lib/error.rs b/roles/translator/src/lib/error.rs
@@ -78,7 +78,7 @@ pub enum Error<'a> {
     Sv1MessageTooLong,
 }
 
-impl<'a> fmt::Display for Error<'a> {
+impl fmt::Display for Error<'_> {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         use Error::*;
         match self {
@@ -118,49 +118,49 @@ impl<'a> fmt::Display for Error<'a> {
     }
 }
 
-impl<'a> From<binary_sv2::Error> for Error<'a> {
+impl From<binary_sv2::Error> for Error<'_> {
     fn from(e: binary_sv2::Error) -> Self {
         Error::BinarySv2(e)
     }
 }
 
-impl<'a> From<codec_sv2::noise_sv2::Error> for Error<'a> {
+impl From<codec_sv2::noise_sv2::Error> for Error<'_> {
     fn from(e: codec_sv2::noise_sv2::Error) -> Self {
         Error::CodecNoise(e)
     }
 }
 
-impl<'a> From<framing_sv2::Error> for Error<'a> {
+impl From<framing_sv2::Error> for Error<'_> {
     fn from(e: framing_sv2::Error) -> Self {
         Error::FramingSv2(e)
     }
 }
 
-impl<'a> From<std::io::Error> for Error<'a> {
+impl From<std::io::Error> for Error<'_> {
     fn from(e: std::io::Error) -> Self {
         Error::Io(e)
     }
 }
 
-impl<'a> From<std::num::ParseIntError> for Error<'a> {
+impl From<std::num::ParseIntError> for Error<'_> {
     fn from(e: std::num::ParseIntError) -> Self {
         Error::ParseInt(e)
     }
 }
 
-impl<'a> From<roles_logic_sv2::errors::Error> for Error<'a> {
+impl From<roles_logic_sv2::errors::Error> for Error<'_> {
     fn from(e: roles_logic_sv2::errors::Error) -> Self {
         Error::RolesSv2Logic(e)
     }
 }
 
-impl<'a> From<serde_json::Error> for Error<'a> {
+impl From<serde_json::Error> for Error<'_> {
     fn from(e: serde_json::Error) -> Self {
         Error::BadSerdeJson(e)
     }
 }
 
-impl<'a> From<ConfigError> for Error<'a> {
+impl From<ConfigError> for Error<'_> {
     fn from(e: ConfigError) -> Self {
         Error::BadConfigDeserialize(e)
     }
@@ -172,20 +172,20 @@ impl<'a> From<v1::error::Error<'a>> for Error<'a> {
     }
 }
 
-impl<'a> From<async_channel::RecvError> for Error<'a> {
+impl From<async_channel::RecvError> for Error<'_> {
     fn from(e: async_channel::RecvError) -> Self {
         Error::ChannelErrorReceiver(e)
     }
 }
 
-impl<'a> From<tokio::sync::broadcast::error::RecvError> for Error<'a> {
+impl From<tokio::sync::broadcast::error::RecvError> for Error<'_> {
     fn from(e: tokio::sync::broadcast::error::RecvError) -> Self {
         Error::TokioChannelErrorRecv(e)
     }
 }
 
 //*** LOCK ERRORS ***
-impl<'a, T> From<PoisonError<T>> for Error<'a> {
+impl<T> From<PoisonError<T>> for Error<'_> {
     fn from(_e: PoisonError<T>) -> Self {
         Error::PoisonLock
     }
@@ -216,13 +216,13 @@ impl<'a> From<tokio::sync::broadcast::error::SendError<Notify<'a>>> for Error<'a
     }
 }
 
-impl<'a> From<async_channel::SendError<v1::Message>> for Error<'a> {
+impl From<async_channel::SendError<v1::Message>> for Error<'_> {
     fn from(e: async_channel::SendError<v1::Message>) -> Self {
         Error::ChannelErrorSender(ChannelSendError::V1Message(e))
     }
 }
 
-impl<'a> From<async_channel::SendError<(ExtendedExtranonce, u32)>> for Error<'a> {
+impl From<async_channel::SendError<(ExtendedExtranonce, u32)>> for Error<'_> {
     fn from(e: async_channel::SendError<(ExtendedExtranonce, u32)>) -> Self {
         Error::ChannelErrorSender(ChannelSendError::Extranonce(e))
     }
@@ -258,25 +258,25 @@ impl<'a>
     }
 }
 
-impl<'a> From<Vec<u8>> for Error<'a> {
+impl From<Vec<u8>> for Error<'_> {
     fn from(e: Vec<u8>) -> Self {
         Error::VecToSlice32(e)
     }
 }
 
-impl<'a> From<ParseLengthError> for Error<'a> {
+impl From<ParseLengthError> for Error<'_> {
     fn from(e: ParseLengthError) -> Self {
         Error::Uint256Conversion(e)
     }
 }
 
-impl<'a> From<SetDifficulty> for Error<'a> {
+impl From<SetDifficulty> for Error<'_> {
     fn from(e: SetDifficulty) -> Self {
         Error::SetDifficultyToMessage(e)
     }
 }
 
-impl<'a> From<std::convert::Infallible> for Error<'a> {
+impl From<std::convert::Infallible> for Error<'_> {
     fn from(e: std::convert::Infallible) -> Self {
         Error::Infallible(e)
     }

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ pub enum Error<'a> {`
`61`	`61`	`Infallible(std::convert::Infallible),`
`62`	`62`	`}`
`63`	`63`
`64`		`-impl<'a> fmt::Display for Error<'a> {`
	`64`	`+impl fmt::Display for Error<'_> {`
`65`	`65`	`fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {`
`66`	`66`	`use Error::*;`
`67`	`67`	`match self {`
`@@ -86,55 +86,55 @@ impl<'a> fmt::Display for Error<'a> {`
`86`	`86`	`}`
`87`	`87`	`}`
`88`	`88`
`89`		`-impl<'a> From<binary_sv2::Error> for Error<'a> {`
	`89`	`+impl From<binary_sv2::Error> for Error<'_> {`
`90`	`90`	`fn from(e: binary_sv2::Error) -> Self {`
`91`	`91`	`Error::BinarySv2(e)`
`92`	`92`	`}`
`93`	`93`	`}`
`94`	`94`
`95`		`-impl<'a> From<codec_sv2::noise_sv2::Error> for Error<'a> {`
	`95`	`+impl From<codec_sv2::noise_sv2::Error> for Error<'_> {`
`96`	`96`	`fn from(e: codec_sv2::noise_sv2::Error) -> Self {`
`97`	`97`	`Error::CodecNoise(e)`
`98`	`98`	`}`
`99`	`99`	`}`
`100`	`100`
`101`		`-impl<'a> From<framing_sv2::Error> for Error<'a> {`
	`101`	`+impl From<framing_sv2::Error> for Error<'_> {`
`102`	`102`	`fn from(e: framing_sv2::Error) -> Self {`
`103`	`103`	`Error::FramingSv2(e)`
`104`	`104`	`}`
`105`	`105`	`}`
`106`	`106`
`107`		`-impl<'a> From<std::io::Error> for Error<'a> {`
	`107`	`+impl From<std::io::Error> for Error<'_> {`
`108`	`108`	`fn from(e: std::io::Error) -> Self {`
`109`	`109`	`Error::Io(e)`
`110`	`110`	`}`
`111`	`111`	`}`
`112`	`112`
`113`		`-impl<'a> From<std::num::ParseIntError> for Error<'a> {`
	`113`	`+impl From<std::num::ParseIntError> for Error<'_> {`
`114`	`114`	`fn from(e: std::num::ParseIntError) -> Self {`
`115`	`115`	`Error::ParseInt(e)`
`116`	`116`	`}`
`117`	`117`	`}`
`118`	`118`
`119`		`-impl<'a> From<roles_logic_sv2::errors::Error> for Error<'a> {`
	`119`	`+impl From<roles_logic_sv2::errors::Error> for Error<'_> {`
`120`	`120`	`fn from(e: roles_logic_sv2::errors::Error) -> Self {`
`121`	`121`	`Error::RolesSv2Logic(e)`
`122`	`122`	`}`
`123`	`123`	`}`
`124`	`124`
`125`		`-impl<'a> From<ConfigError> for Error<'a> {`
	`125`	`+impl From<ConfigError> for Error<'_> {`
`126`	`126`	`fn from(e: ConfigError) -> Self {`
`127`	`127`	`Error::BadConfigDeserialize(e)`
`128`	`128`	`}`
`129`	`129`	`}`
`130`	`130`
`131`		`-impl<'a> From<async_channel::RecvError> for Error<'a> {`
	`131`	`+impl From<async_channel::RecvError> for Error<'_> {`
`132`	`132`	`fn from(e: async_channel::RecvError) -> Self {`
`133`	`133`	`Error::ChannelErrorReceiver(e)`
`134`	`134`	`}`
`135`	`135`	`}`
`136`	`136`
`137`		`-impl<'a> From<tokio::sync::broadcast::error::RecvError> for Error<'a> {`
	`137`	`+impl From<tokio::sync::broadcast::error::RecvError> for Error<'_> {`
`138`	`138`	`fn from(e: tokio::sync::broadcast::error::RecvError) -> Self {`
`139`	`139`	`Error::TokioChannelErrorRecv(e)`
`140`	`140`	`}`
`@@ -176,7 +176,7 @@ impl<'a> From<async_channel::SendError<roles_logic_sv2::mining_sv2::SetNewPrevHa`
`176`	`176`	`}`
`177`	`177`	`}`
`178`	`178`
`179`		`-impl<'a> From<async_channel::SendError<(ExtendedExtranonce, u32)>> for Error<'a> {`
	`179`	`+impl From<async_channel::SendError<(ExtendedExtranonce, u32)>> for Error<'_> {`
`180`	`180`	`fn from(e: async_channel::SendError<(ExtendedExtranonce, u32)>) -> Self {`
`181`	`181`	`Error::ChannelErrorSender(ChannelSendError::Extranonce(e))`
`182`	`182`	`}`
`@@ -212,13 +212,13 @@ impl<'a>`
`212`	`212`	`}`
`213`	`213`	`}`
`214`	`214`
`215`		`-impl<'a> From<ParseLengthError> for Error<'a> {`
	`215`	`+impl From<ParseLengthError> for Error<'_> {`
`216`	`216`	`fn from(e: ParseLengthError) -> Self {`
`217`	`217`	`Error::Uint256Conversion(e)`
`218`	`218`	`}`
`219`	`219`	`}`
`220`	`220`
`221`		`-impl<'a> From<std::convert::Infallible> for Error<'a> {`
	`221`	`+impl From<std::convert::Infallible> for Error<'_> {`
`222`	`222`	`fn from(e: std::convert::Infallible) -> Self {`
`223`	`223`	`Error::Infallible(e)`
`224`	`224`	`}`
Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ impl ParseServerJobDeclarationMessages for JobDeclarator {`
`67`	`67`	`None`
`68`	`68`	`}`
`69`	`69`	`})`
`70`		`- .ok_or_else(\|\| Error::UnknownRequestId(message.request_id))?;`
	`70`	`+ .ok_or(Error::UnknownRequestId(message.request_id))?;`
`71`	`71`
`72`	`72`	`let unknown_tx_position_list: Vec<u16> = message.unknown_tx_position_list.into_inner();`
`73`	`73`	`let missing_transactions: Vec<binary_sv2::B016M> = unknown_tx_position_list`
Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ pub enum Error<'a> {`
`78`	`78`	`Sv1MessageTooLong,`
`79`	`79`	`}`
`80`	`80`
`81`		`-impl<'a> fmt::Display for Error<'a> {`
	`81`	`+impl fmt::Display for Error<'_> {`
`82`	`82`	`fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {`
`83`	`83`	`use Error::*;`
`84`	`84`	`match self {`
`@@ -118,49 +118,49 @@ impl<'a> fmt::Display for Error<'a> {`
`118`	`118`	`}`
`119`	`119`	`}`
`120`	`120`
`121`		`-impl<'a> From<binary_sv2::Error> for Error<'a> {`
	`121`	`+impl From<binary_sv2::Error> for Error<'_> {`
`122`	`122`	`fn from(e: binary_sv2::Error) -> Self {`
`123`	`123`	`Error::BinarySv2(e)`
`124`	`124`	`}`
`125`	`125`	`}`
`126`	`126`
`127`		`-impl<'a> From<codec_sv2::noise_sv2::Error> for Error<'a> {`
	`127`	`+impl From<codec_sv2::noise_sv2::Error> for Error<'_> {`
`128`	`128`	`fn from(e: codec_sv2::noise_sv2::Error) -> Self {`
`129`	`129`	`Error::CodecNoise(e)`
`130`	`130`	`}`
`131`	`131`	`}`
`132`	`132`
`133`		`-impl<'a> From<framing_sv2::Error> for Error<'a> {`
	`133`	`+impl From<framing_sv2::Error> for Error<'_> {`
`134`	`134`	`fn from(e: framing_sv2::Error) -> Self {`
`135`	`135`	`Error::FramingSv2(e)`
`136`	`136`	`}`
`137`	`137`	`}`
`138`	`138`
`139`		`-impl<'a> From<std::io::Error> for Error<'a> {`
	`139`	`+impl From<std::io::Error> for Error<'_> {`
`140`	`140`	`fn from(e: std::io::Error) -> Self {`
`141`	`141`	`Error::Io(e)`
`142`	`142`	`}`
`143`	`143`	`}`
`144`	`144`
`145`		`-impl<'a> From<std::num::ParseIntError> for Error<'a> {`
	`145`	`+impl From<std::num::ParseIntError> for Error<'_> {`
`146`	`146`	`fn from(e: std::num::ParseIntError) -> Self {`
`147`	`147`	`Error::ParseInt(e)`
`148`	`148`	`}`
`149`	`149`	`}`
`150`	`150`
`151`		`-impl<'a> From<roles_logic_sv2::errors::Error> for Error<'a> {`
	`151`	`+impl From<roles_logic_sv2::errors::Error> for Error<'_> {`
`152`	`152`	`fn from(e: roles_logic_sv2::errors::Error) -> Self {`
`153`	`153`	`Error::RolesSv2Logic(e)`
`154`	`154`	`}`
`155`	`155`	`}`
`156`	`156`
`157`		`-impl<'a> From<serde_json::Error> for Error<'a> {`
	`157`	`+impl From<serde_json::Error> for Error<'_> {`
`158`	`158`	`fn from(e: serde_json::Error) -> Self {`
`159`	`159`	`Error::BadSerdeJson(e)`
`160`	`160`	`}`
`161`	`161`	`}`
`162`	`162`
`163`		`-impl<'a> From<ConfigError> for Error<'a> {`
	`163`	`+impl From<ConfigError> for Error<'_> {`
`164`	`164`	`fn from(e: ConfigError) -> Self {`
`165`	`165`	`Error::BadConfigDeserialize(e)`
`166`	`166`	`}`
`@@ -172,20 +172,20 @@ impl<'a> From<v1::error::Error<'a>> for Error<'a> {`
`172`	`172`	`}`
`173`	`173`	`}`
`174`	`174`
`175`		`-impl<'a> From<async_channel::RecvError> for Error<'a> {`
	`175`	`+impl From<async_channel::RecvError> for Error<'_> {`
`176`	`176`	`fn from(e: async_channel::RecvError) -> Self {`
`177`	`177`	`Error::ChannelErrorReceiver(e)`
`178`	`178`	`}`
`179`	`179`	`}`
`180`	`180`
`181`		`-impl<'a> From<tokio::sync::broadcast::error::RecvError> for Error<'a> {`
	`181`	`+impl From<tokio::sync::broadcast::error::RecvError> for Error<'_> {`
`182`	`182`	`fn from(e: tokio::sync::broadcast::error::RecvError) -> Self {`
`183`	`183`	`Error::TokioChannelErrorRecv(e)`
`184`	`184`	`}`
`185`	`185`	`}`
`186`	`186`
`187`	`187`	`//* LOCK ERRORS *`
`188`		`-impl<'a, T> From<PoisonError<T>> for Error<'a> {`
	`188`	`+impl<T> From<PoisonError<T>> for Error<'_> {`
`189`	`189`	`fn from(_e: PoisonError<T>) -> Self {`
`190`	`190`	`Error::PoisonLock`
`191`	`191`	`}`
`@@ -216,13 +216,13 @@ impl<'a> From<tokio::sync::broadcast::error::SendError<Notify<'a>>> for Error<'a`
`216`	`216`	`}`
`217`	`217`	`}`
`218`	`218`
`219`		`-impl<'a> From<async_channel::SendError<v1::Message>> for Error<'a> {`
	`219`	`+impl From<async_channel::SendError<v1::Message>> for Error<'_> {`
`220`	`220`	`fn from(e: async_channel::SendError<v1::Message>) -> Self {`
`221`	`221`	`Error::ChannelErrorSender(ChannelSendError::V1Message(e))`
`222`	`222`	`}`
`223`	`223`	`}`
`224`	`224`
`225`		`-impl<'a> From<async_channel::SendError<(ExtendedExtranonce, u32)>> for Error<'a> {`
	`225`	`+impl From<async_channel::SendError<(ExtendedExtranonce, u32)>> for Error<'_> {`
`226`	`226`	`fn from(e: async_channel::SendError<(ExtendedExtranonce, u32)>) -> Self {`
`227`	`227`	`Error::ChannelErrorSender(ChannelSendError::Extranonce(e))`
`228`	`228`	`}`
`@@ -258,25 +258,25 @@ impl<'a>`
`258`	`258`	`}`
`259`	`259`	`}`
`260`	`260`
`261`		`-impl<'a> From<Vec<u8>> for Error<'a> {`
	`261`	`+impl From<Vec<u8>> for Error<'_> {`
`262`	`262`	`fn from(e: Vec<u8>) -> Self {`
`263`	`263`	`Error::VecToSlice32(e)`
`264`	`264`	`}`
`265`	`265`	`}`
`266`	`266`
`267`		`-impl<'a> From<ParseLengthError> for Error<'a> {`
	`267`	`+impl From<ParseLengthError> for Error<'_> {`
`268`	`268`	`fn from(e: ParseLengthError) -> Self {`
`269`	`269`	`Error::Uint256Conversion(e)`
`270`	`270`	`}`
`271`	`271`	`}`
`272`	`272`
`273`		`-impl<'a> From<SetDifficulty> for Error<'a> {`
	`273`	`+impl From<SetDifficulty> for Error<'_> {`
`274`	`274`	`fn from(e: SetDifficulty) -> Self {`
`275`	`275`	`Error::SetDifficultyToMessage(e)`
`276`	`276`	`}`
`277`	`277`	`}`
`278`	`278`
`279`		`-impl<'a> From<std::convert::Infallible> for Error<'a> {`
	`279`	`+impl From<std::convert::Infallible> for Error<'_> {`
`280`	`280`	`fn from(e: std::convert::Infallible) -> Self {`
`281`	`281`	`Error::Infallible(e)`
`282`	`282`	`}`