-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance nodes IBD #50
Conversation
d8b346d
to
da3051e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concept ACK. Just few nits.
How many buffer snapshots are we keeping on the server? For example, if it takes me about 2 hours to download a snapshot, the if
condition if wget $BACKUP_URL -O $BACKUP_FILE && wget $BACKUP_HASH_URL -O $BACKUP_HASH_FILE; then
is gonna download the whole backup_file
first, then the backup_hash_url
to verify its authenticity. If we’re storing a lot of buffer snapshots, that’s fine (as long as it doesn't overload the server). But if we’re only keeping a few, like the last 5 hours’ worth, it could be a problem.
Atm we're keeping last 3 hours. How many do you suggest to keep? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rt-ACK. If we can have the IBD downloaded once and then mount it as a volume for the template provider or node containers, that would be ideal. Everything else looks good.
…mainnet-chainstate.sh script addition healthcheck.sh comments translation
…cated version removal
8e10ccf
to
8f339ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
commented code removal
f896f43
to
30066b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK 30066b2. Snapshot are getting refreshed for new downloads
This PR drastically improves the UX when using the tool on
mainnet
.If it's the first time the tool is run on mainnet, the
update-mainnet-chainstate.sh
script will download the latest snapshot from our VPS, which serves a new snapshot every hour. It will do it also if more than 24 hours have passed since the last time the tool has been used in the mainnet (since it would take a lot of time to sync 3 pruned nodes together).If we still want to support testnet3 (which I wouldn't), I think we should replicate this PR also for that since it takes a lot of time to sync it. Otherwise we can just support
mainnet
andtestnet4
and open an issue to removetestnet3
from the options in therun-benchmarking-tool.sh
and wherever it's mentioned.Close #38