Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: Support for a loading state of Modal #841

Open
gu-stav opened this issue Jan 13, 2023 · 2 comments
Open

[feat]: Support for a loading state of Modal #841

gu-stav opened this issue Jan 13, 2023 · 2 comments
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: design-system relates to design-system package

Comments

@gu-stav
Copy link
Contributor

gu-stav commented Jan 13, 2023

A clear and concise description of what the feature is

I'd like to see loading state support for modals.

Why should this feature be included?

In the monorepo we have a growing number of modals which have to load data when they are being opened, or where data is validated async once a form within a modal is submitted.

In both cases the modal will be in a loading state.

Examples:

Note: all of these examples use slightly different patterns to display the Loader

Please provide an example for how this would work

  • DialogBody could have an isLoading prop which could render the loading state
@gu-stav gu-stav added the issue: enhancement Issue suggesting an enhancement to an existing feature label Jan 13, 2023
@gu-stav
Copy link
Contributor Author

gu-stav commented Jan 17, 2023

@maevalienard Here the issue we've just discussed: we'd like to support a consistent loading state for modals, because we are using different patterns in different places. One thing to keep in mind may be is that the loader should enforce some minimum height on the modal, so that it doesn't jump around too much when the data comes and it is not in a loading state anymore.

@maevalienard
Copy link
Contributor

maevalienard commented Jan 17, 2023

@gu-stav Gotcha, thanks! By any chance, do you know what the min height is please? (is it the min or the max height that we will display by default for the loading state though?)

@joshuaellis joshuaellis added the source: design-system relates to design-system package label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: design-system relates to design-system package
Projects
None yet
Development

No branches or pull requests

3 participants