Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Cleaner search bar #1832

Open
lucasboilly opened this issue Dec 4, 2024 · 2 comments · May be fixed by #1833
Open

[bug]: Cleaner search bar #1832

lucasboilly opened this issue Dec 4, 2024 · 2 comments · May be fixed by #1833
Assignees
Labels
good first issue Good for newcomers issue: bug Issue reporting a bug

Comments

@lucasboilly
Copy link

lucasboilly commented Dec 4, 2024

What version of design-system are you using?

Browser: Arc

What's Wrong?

Since it's displayed next to 32px elements (ex: the filter button of the list view), it makes the layout shift when it's opened. On the UI side, it simply doesn't look like it's part of our design system (icon color, shadow, no borders). The colors are also not the right ones in dark mode.

CleanShot.2024-12-04.at.10.57.58.mp4

To Reproduce

Click on any search bar, in the list view for example.

Expected Behaviour

The Search icon should have a 16px size and a Neutral500 color. The color of the placeholder text should be Neutral500 as well. The input itself should have a 32px height and a 8px paddings Please find the other measurements in the following screenshot.

CleanShot 2024-12-04 at 11 09 18@2x

With all these modifications, the transition between the collapsed and expanded mode should be smoother.

CleanShot.2024-12-04.at.11.14.45.mp4
@lucasboilly lucasboilly added good first issue Good for newcomers issue: bug Issue reporting a bug labels Dec 4, 2024
@lucasboilly lucasboilly self-assigned this Dec 4, 2024
@ShatilKhan
Copy link

I'm looking into it. Can you assign me @lucasboilly ?

@ShatilKhan ShatilKhan linked a pull request Dec 6, 2024 that will close this issue
@lucasboilly
Copy link
Author

Hi @ShatilKhan, sorry I missed the notification!

Thanks for your contribution, I'm gonna check the design today and I'll let the team know about your PR 🙂

@lucasboilly lucasboilly linked a pull request Dec 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers issue: bug Issue reporting a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants