Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: Better disabled state for CarouselInput #1817

Open
lucasboilly opened this issue Nov 7, 2024 · 2 comments
Open

[feat]: Better disabled state for CarouselInput #1817

lucasboilly opened this issue Nov 7, 2024 · 2 comments
Assignees
Labels
good first issue Good for newcomers issue: enhancement Issue suggesting an enhancement to an existing feature

Comments

@lucasboilly
Copy link

lucasboilly commented Nov 7, 2024

A clear and concise description of what the feature is

The input doesn't use the disabled colors as the other ones.

CleanShot 2024-11-07 at 13 16 49@2x

On an empty input, the hover area making the cursor change is smaller than the input.

CleanShot.2024-11-07.at.13.10.04.mp4

On a filled input, the cursor doesn't change to it's disabled form.

CleanShot.2024-11-07.at.13.14.19.mp4

Why should this feature be included?

Users might not understand that the input is disabled.

Please provide an example for how this would work

The input doesn't use the disabled colors as the other ones.

For this one, the background should be Neutral150 and the border Neutral200.

@lucasboilly lucasboilly added good first issue Good for newcomers issue: enhancement Issue suggesting an enhancement to an existing feature labels Nov 7, 2024
@lucasboilly lucasboilly self-assigned this Nov 7, 2024
@lucasboilly
Copy link
Author

I also would like to reduce the gap between the icon and the text to 8px.

@chitangchin
Copy link
Contributor

I wanted to comment that potential solution for this Issue may be linked to my solution proposal in [bug]: Missing disabled cursors on various inputs #1823

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers issue: enhancement Issue suggesting an enhancement to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants