Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug]: <DatePicker /> component autoComplete prop #1797

Open
alexandermirzoyan opened this issue Oct 11, 2024 · 1 comment · May be fixed by #1798
Open

[bug]: <DatePicker /> component autoComplete prop #1797

alexandermirzoyan opened this issue Oct 11, 2024 · 1 comment · May be fixed by #1798
Labels
community issue: bug Issue reporting a bug status: pending reproduction Waiting for free time to reproduce the issue, or more information

Comments

@alexandermirzoyan
Copy link

What version of design-system are you using?

  • Strapi Design System - v1.14.1
  • Browser - Google Chrome v129.0.6668.91

What's Wrong?

When focusing on <DatePicker /> component browser's default auto complete feature is working and some options are being suggested from the browser browser.

DatePicker autoComplete screenshot

To Reproduce

  • Click on input area of the <DatePicker /> component when the input is empty

Expected Behaviour

There should not be browser's default auto complete feature enabled.
@alexandermirzoyan alexandermirzoyan added issue: bug Issue reporting a bug status: pending reproduction Waiting for free time to reproduce the issue, or more information labels Oct 11, 2024
@alexandermirzoyan
Copy link
Author

As a solution I suggest to pass autoComplete="off" prop by default at packages/design-system/src/components/DatePicker/DatePicker.tsx file's <DatePickerTextInput /> component.

I will open a PR for this today.

@alexandermirzoyan alexandermirzoyan linked a pull request Oct 11, 2024 that will close this issue
Open
@markkaylor markkaylor linked a pull request Nov 26, 2024 that will close this issue
<DatePicker /> component autoComplete issue #1798
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community issue: bug Issue reporting a bug status: pending reproduction Waiting for free time to reproduce the issue, or more information
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

<DatePicker /> component autoComplete issue alexandermirzoyan/design-system
2 participants
@oiorain @alexandermirzoyan