Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unsound impl Bytes for bool and char #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove unsound impl Bytes for bool and char #101

wants to merge 1 commit into from

Conversation

zachs18
Copy link

@zachs18 zachs18 commented May 25, 2022

bool and char are not able to have any arbitrary bit-pattern, so they should not implement Bytes.

fixes #100

@zachs18
Remove unsound impl Bytes for bool and char
cd07f36 
`bool` and `char` are not able to have any arbitrary bit-pattern, so they should not implement `Bytes`.

fixes stouset#100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bool and char's Bytes implementations cause undefined behavior.
1 participant
@zachs18