memory: Drop workaround for to_address

stotko · Aug 27, 2024 · 3333da6 · 3333da6
1 parent a5ea998
commit 3333da6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 27 deletions.
diff --git a/src/stdgpu/impl/memory_detail.h b/src/stdgpu/impl/memory_detail.h
@@ -670,9 +670,6 @@ to_address(T* p) noexcept
     return p;
 }
 
-// Use pre-C++17 SFINAE for dispatching due to wrong missing-return warning caused by NVCC
-// (potentially fixed in CUDA 11.5+)
-/*
 template <typename Ptr>
 STDGPU_HOST_DEVICE auto
 to_address(const Ptr& p) noexcept
@@ -693,22 +690,6 @@ to_address(const Ptr& p) noexcept
         return static_cast<void*>(nullptr);
     }
 }
-*/
-
-template <typename Ptr, STDGPU_DETAIL_OVERLOAD_DEFINITION_IF(detail::has_arrow_operator_v<Ptr>)>
-STDGPU_HOST_DEVICE auto
-to_address(const Ptr& p) noexcept
-{
-    return to_address(p.operator->());
-}
-
-template <typename Ptr,
-          STDGPU_DETAIL_OVERLOAD_DEFINITION_IF(!detail::has_arrow_operator_v<Ptr> && detail::has_get_v<Ptr>)>
-STDGPU_HOST_DEVICE auto
-to_address(const Ptr& p) noexcept
-{
-    return to_address(p.get());
-}
 
 template <typename T, typename... Args>
 STDGPU_HOST_DEVICE T*

diff --git a/src/stdgpu/memory.h b/src/stdgpu/memory.h
@@ -741,18 +741,12 @@ to_address(T* p) noexcept;
  * \brief Converts a potential fancy pointer to a raw pointer
  * \tparam Ptr The fancy pointer type
  * \param[in] p A fancy pointer
- * \return The raw pointer held by the fancy pointer obtained via operator->()
+ * \return The raw pointer held by the fancy pointer obtained via operator->() or get()
  */
-template <typename Ptr, STDGPU_DETAIL_OVERLOAD_IF(detail::has_arrow_operator_v<Ptr>)>
+template <typename Ptr>
 STDGPU_HOST_DEVICE auto
 to_address(const Ptr& p) noexcept;
 
-//! @cond Doxygen_Suppress
-template <typename Ptr, STDGPU_DETAIL_OVERLOAD_IF(!detail::has_arrow_operator_v<Ptr> && detail::has_get_v<Ptr>)>
-STDGPU_HOST_DEVICE auto
-to_address(const Ptr& p) noexcept;
-//! @endcond
-
 /**
  * \ingroup memory
  * \brief Destroys the value at the given pointer