You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
collectRoyaltyTokens, claimableRevenue, claimRevenue, snapshot, and getRoyaltyVaultAddress should use a different variable name instead of royaltyVaultIpId. This is unclear to users because users are supposed to pass in the derivative/child ip id so that we can calculate the proxy address of the vault but this does not seem obvious by documentation or variable names.
Suggested solution
Rename variable to childIpId to be more clear and update docs
Definition of done
Code merged and documentation updated
The text was updated successfully, but these errors were encountered:
aandrewchung
changed the title
Rename variable "royaltyVaultIpId" (and respective docs) to childIpId
Variable "royaltyVaultIpId" (and respective docs) unclear
May 24, 2024
Description and context
collectRoyaltyTokens, claimableRevenue, claimRevenue, snapshot, and getRoyaltyVaultAddress should use a different variable name instead of royaltyVaultIpId. This is unclear to users because users are supposed to pass in the derivative/child ip id so that we can calculate the proxy address of the vault but this does not seem obvious by documentation or variable names.
Suggested solution
Rename variable to childIpId to be more clear and update docs
Definition of done
Code merged and documentation updated
The text was updated successfully, but these errors were encountered: