Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Signature Requirements for SPG Functions #31

Open
sebsadface opened this issue Aug 20, 2024 · 1 comment
Open

Simplify Signature Requirements for SPG Functions #31

sebsadface opened this issue Aug 20, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@sebsadface
Copy link
Member

Description

Currently, registerIpAndAttachPILTerms, registerIpAndMakeDerivative, andregisterIpAndMakeDerivativeWithLicenseTokens in the SPG requires multiple signatures to set permission, which adds complexity for developments. To improve developer experience, we can modify this function to require only a single signature by utilizing the setBatchPermissions method in core protocol's AccessController contract.

@sebsadface sebsadface self-assigned this Aug 20, 2024
@sebsadface sebsadface added the enhancement New feature or request label Aug 20, 2024
@sebsadface
Copy link
Member Author

As we transition from the set permission model to using executeWithSig from IPAccount for security reasons (refer to #121), further simplifying the signature requirements is not currently feasible. Each executeWithSig call requires a unique signature, which limits our ability to simplify this process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant