Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve upgradeability of IPAcounts #201

Open
Ramarti opened this issue Aug 18, 2024 · 0 comments
Open

Improve upgradeability of IPAcounts #201

Ramarti opened this issue Aug 18, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@Ramarti
Copy link

Ramarti commented Aug 18, 2024

Description

Currently, when we upgrade IPAccountImpl via upgrading IPAssetRegistry, all previous IPAccounts will stop being considered registered. IPAs should re register and move assets.

We should improve this with versioning.

Interface checks are also problematic to check for registration, since new versions of IIPAccount might be introduced.
This will affect IPAccountChecker too, which is used across the protocol

Solution

  • Store version on IPAccount registration, either in IPAccountStorage or as part of IPAccount interface
  • Check version in isRegistered calls to know which implementation address use to generate IPAccount address
  • Consider eliminating ERC165 checks on IIPAccount

Test plan

  • Register IPA
  • Upgrade IPAssetRegistry with a different IPAccountImpl
  • Register 2nd IPA
  • Both should return true when asking isRegistered
@Ramarti Ramarti added the enhancement New feature or request label Aug 18, 2024
@Ramarti Ramarti self-assigned this Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant