You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, when we upgrade IPAccountImpl via upgrading IPAssetRegistry, all previous IPAccounts will stop being considered registered. IPAs should re register and move assets.
We should improve this with versioning.
Interface checks are also problematic to check for registration, since new versions of IIPAccount might be introduced.
This will affect IPAccountChecker too, which is used across the protocol
Solution
Store version on IPAccount registration, either in IPAccountStorage or as part of IPAccount interface
Check version in isRegistered calls to know which implementation address use to generate IPAccount address
Consider eliminating ERC165 checks on IIPAccount
Test plan
Register IPA
Upgrade IPAssetRegistry with a different IPAccountImpl
Register 2nd IPA
Both should return true when asking isRegistered
The text was updated successfully, but these errors were encountered:
Description
Currently, when we upgrade
IPAccountImpl
via upgradingIPAssetRegistry
, all previous IPAccounts will stop being considered registered. IPAs should re register and move assets.We should improve this with versioning.
Interface checks are also problematic to check for registration, since new versions of
IIPAccount
might be introduced.This will affect
IPAccountChecker
too, which is used across the protocolSolution
isRegistered
calls to know which implementation address use to generate IPAccount addressTest plan
IPAssetRegistry
with a differentIPAccountImpl
isRegistered
The text was updated successfully, but these errors were encountered: