You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As reported by Trust sec, mintLicense() could be frontrun by the seller changing the licensing terms to a higher price than the buyer is expecting.
Suggested solution
Adding a maxPrice parameter as user input in mintLicenseTokens, similar to how AMMs allows the user to set slippage limits to protect against fluctuations in price.
To be able to enforce it, ERC20 transfers must happen at the LicensingModule level, Royalty Policies must return the price instead.
Definition of done
Scenario tested, code merged and deployed.
The text was updated successfully, but these errors were encountered:
Description and context
As reported by Trust sec, mintLicense() could be frontrun by the seller changing the licensing terms to a higher price than the buyer is expecting.
Suggested solution
Adding a
maxPrice
parameter as user input inmintLicenseTokens
, similar to how AMMs allows the user to set slippage limits to protect against fluctuations in price.To be able to enforce it, ERC20 transfers must happen at the LicensingModule level, Royalty Policies must return the price instead.
Definition of done
Scenario tested, code merged and deployed.
The text was updated successfully, but these errors were encountered: