Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Сonsecutive channel events on storybook@8 with "@storybook/react-webpack5" cause page to reload #30118

Open
KuznetsovRoman opened this issue Dec 20, 2024 · 0 comments

Comments

@KuznetsovRoman
Copy link

Describe the bug

When using storybook@8, react-webpack@5, emitting some consecutive events leads page to reload.
The problem does not reproduce when using react-vite.

"page reload" is the problem here

Reproduction link

https://stackblitz.com/edit/github-axcvs6ro

Reproduction steps

  1. Go to above link
  2. Open "example-button--primary" story
  3. Execute the following script in devtools inside "storybook-preview-iframe" frame:
window.__STORYBOOK_ADDONS_CHANNEL__.emit("updateGlobals", {globals: window.__STORYBOOK_ADDONS_CHANNEL__.data.setGlobals[0].globals})
window.__STORYBOOK_ADDONS_CHANNEL__.emit("setCurrentStory", { storyId: "" })
window.__STORYBOOK_ADDONS_CHANNEL__.emit("setCurrentStory", { storyId: "example-button--primary" })

This leads page to reload.

after removing "updateGlobals" call or "setCurrentStory" call, page won't reload.

System

Storybook Environment Info:

  System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.20.3 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn <----- active
    npm: 10.2.3 - /usr/local/bin/npm
    pnpm: 8.15.6 - /usr/local/bin/pnpm
  npmPackages:
    @storybook/addon-essentials: ^8.5.0-beta.3 => 8.5.0-beta.3 
    @storybook/addon-interactions: ^8.5.0-beta.3 => 8.5.0-beta.3 
    @storybook/addon-onboarding: ^8.5.0-beta.3 => 8.5.0-beta.3 
    @storybook/addon-webpack5-compiler-swc: ^1.0.5 => 1.0.5 
    @storybook/blocks: ^8.5.0-beta.3 => 8.5.0-beta.3 
    @storybook/react: ^8.5.0-beta.3 => 8.5.0-beta.3 
    @storybook/react-webpack5: ^8.5.0-beta.3 => 8.5.0-beta.3 
    @storybook/test: ^8.5.0-beta.3 => 8.5.0-beta.3 
    storybook: ^8.5.0-beta.3 => 8.5.0-beta.3

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant