Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] revisit dependency optimization behavior #29812

Open
Tracked by #29531
yannbf opened this issue Dec 4, 2024 · 0 comments · May be fixed by #30117
Open
Tracked by #29531

[Bug] revisit dependency optimization behavior #29812

yannbf opened this issue Dec 4, 2024 · 0 comments · May be fixed by #30117

Comments

@yannbf
Copy link
Member

yannbf commented Dec 4, 2024

When Vite optimizes dependencies (as they are requested), it hard reloads which causes both a bad loading behavior in Storybook:

As well as potential flake in Vitest:

Seems like the issue started in alpha 16. There is a bugfix from alpha 17 to make Storybook run though, so whoever works on this can investigate from that version if they prefer. I suspect it has to do with this change.

There is a reproduction you can check at https://github.com/yannbf/inkline-sb-qa on the sb-85-qa branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Empathy Backlog
Development

Successfully merging a pull request may close this issue.

2 participants