Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: storybook init --skip-install still broken #29112

Closed
benmccann opened this issue Sep 13, 2024 · 3 comments · Fixed by #29133
Closed

[Bug]: storybook init --skip-install still broken #29112

benmccann opened this issue Sep 13, 2024 · 3 comments · Fixed by #29133
Labels
bug cli

Comments

@benmccann
Copy link
Contributor

Describe the bug

pnpx storybook init --skip-install generates:

  "devDependencies": {
    "@fontsource/fira-mono": "^4.5.10",
    "@neoconfetti/svelte": "^1.0.0",
    "@sveltejs/adapter-auto": "^3.0.0",
    "@sveltejs/kit": "^2.0.0",
    "@sveltejs/vite-plugin-svelte": "^3.0.0",
    "svelte": "^4.2.7",
    "svelte-check": "^3.6.0",
    "typescript": "^5.0.0",
    "vite": "^5.0.3",
    "@storybook/addon-svelte-csf": "^4.1.7",
    "@chromatic-com/storybook": "^1.9.0"
  },

pnpx storybook init generates:

  "devDependencies": {
    "@chromatic-com/storybook": "^1.9.0",
    "@fontsource/fira-mono": "^4.5.10",
    "@neoconfetti/svelte": "^1.0.0",
    "@storybook/addon-essentials": "^8.3.0",
    "@storybook/addon-interactions": "^8.3.0",
    "@storybook/addon-links": "^8.3.0",
    "@storybook/addon-svelte-csf": "^4.1.7",
    "@storybook/blocks": "^8.3.0",
    "@storybook/svelte": "^8.3.0",
    "@storybook/sveltekit": "^8.3.0",
    "@storybook/test": "^8.3.0",
    "@sveltejs/adapter-auto": "^3.0.0",
    "@sveltejs/kit": "^2.0.0",
    "@sveltejs/vite-plugin-svelte": "^3.0.0",
    "storybook": "^8.3.0",
    "svelte": "^4.2.7",
    "svelte-check": "^3.6.0",
    "typescript": "^5.0.0",
    "vite": "^5.0.3"
  },

Reproduction link

see steps below

Reproduction steps

pnpm create svelte@latest myapp
cd myapp
pnpx storybook init --skip-install

System

storybook 8.3.0

Additional context

I think this is at least the third time we've reported this bug. It keeps being fixed in pre-releases and then broken in the final release

The last attempt at fixing this was #28853. I'm not sure how come it didn't stick or the tests didn't catch that it broke again
@shilman shilman added cli and removed needs triage labels Sep 13, 2024
@shilman
Copy link
Member

shilman commented Sep 13, 2024

@kasperpeulen @ndelangen @JReinhold @vanessayuenn

Can we please:

  1. Fix this in empathy
  2. Make sure that it's well-tested in CI so we don't regress?

@valentinpalkovic
Copy link
Contributor

@shilman I can take care of it on Monday since I am taking over empathy from Kasper for a week.

@valentinpalkovic valentinpalkovic mentioned this issue Sep 16, 2024
Merged
8 tasks
@benmccann
Copy link
Contributor Author

Thank you!! You'll soon be able to setup Storybook in the main Svelte CLI for project creation. This is really helpful for us to be able to enable that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug cli
Projects
Core Team Projects
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CLI: Fix skip-install for stable latest releases storybookjs/storybook
3 participants
@benmccann @shilman @valentinpalkovic