Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transitions between states not showing when changeing a knob #40

Open
emattias opened this issue May 26, 2020 · 5 comments
Open

Transitions between states not showing when changeing a knob #40

emattias opened this issue May 26, 2020 · 5 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@emattias
Copy link

emattias commented May 26, 2020

When changing a knob the transitions between states arent showing.

It seems likee the whole component is reinserted everytume. How can I avoid a full re-render/remount?

This is for ember components. I dont know if other frameworks have the same problem.

in app

(animating in/out icon, gif is not fully 60 fps.. :))

CleanShot 2020-05-26 at 22 50 32

in storybook

(not animating in/out icon)

CleanShot 2020-05-26 at 22 49 27

@emattias
Copy link
Author

I got it working :)

@emattias
Copy link
Author

After further investigation it turns out to not work 😅

@emattias emattias reopened this May 26, 2020
@gabrielcsapo gabrielcsapo added the help wanted Extra attention is needed label Jul 1, 2020
@dbendaou
Copy link
Member

dbendaou commented Jul 16, 2020

Indeed, that's because whenever you change a knob parameter it re-render the story itself. I don't think there's a way to solve this with the current config.

I think it require to refact the render method to have a DidUpdate hook when changing a knob parameter https://github.com/storybookjs/storybook/blob/next/app/ember/src/client/preview/render.ts

@gabrielcsapo Am I correct ?

@dbendaou
Copy link
Member

Actually @shilman may have some further informations on it too

@Alonski
Copy link

Alonski commented Aug 10, 2020

@dbendaou @shilman I would love to have this as well :)

@gabrielcsapo gabrielcsapo added the bug Something isn't working label Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants