Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch ui-kit to mosaic #115

Closed
2 of 3 tasks
philsturgeon opened this issue Mar 25, 2021 · 13 comments
Closed
2 of 3 tasks

Switch ui-kit to mosaic #115

philsturgeon opened this issue Mar 25, 2021 · 13 comments

Comments

@philsturgeon
Copy link

philsturgeon commented Mar 25, 2021

Summary

Switch from ui-kit to equivalent mosaic components.

Tasks

  • Make sure all unprefixed Tailwind class names are gone
  • Remove all trace of Blueprint CSS
  • Delete any dependencies relating to ui-kit
@marcelltoth
Copy link
Contributor

FYI there's nothing directly from ui-kit in JSV. The only reason we have it listed is because it's a peer of markdown viewer.

This should be blocked by the MDV issue, as it's non-actionable until that's gone.

@philsturgeon
Copy link
Author

Yep!

@Fox32
Copy link

Fox32 commented Mar 30, 2021

I thought about using json-schema-viewer in Backstage and had a look at the beta releases because of the extended support for newer schema versions. But I noticed that is depends on mosaic which is not open source and doesn't have a license on NPM. Any plans to open source that package?

@philsturgeon
Copy link
Author

philsturgeon commented Mar 30, 2021

Is mosaic blocking you from installing the lib or is it just a legal/licensing concern?

@Fox32
Copy link

Fox32 commented Mar 30, 2021

A legal/licensing concern. Otherwise it works and looks great - theming was a bit difficult with no direct access to the code or docs.

@philsturgeon
Copy link
Author

@Fox32 thanks for letting me know, easy solve: mosaic now contains the Apache license. We're going to tag a new version that makes that clear on NPM, but here you go:

image

@Fox32
Copy link

Fox32 commented Apr 5, 2021

Thanks, looking forward to use the package!

@Fox32
Copy link

Fox32 commented May 3, 2021

Oh, maybe I was a bit eager with using the new version. Looks like moasic doesn't play nicely when getting integrated into existing applications that aren't based on mosaic. CSS is applied globally and is overwriting our CSS rules. Would be cool if there is a way to limit the scope, but I couldn't have a deeper look into it.

@philsturgeon
Copy link
Author

@Fox32 sorry for the trouble. Just to set expectations, we're not really expecting too many folks to use json-schema-viewer directly at the moment. We've not put the time into documenting it, or any of the usual work we normally do with our supported OSS projects like Elements, Prism, or Spectral.

There should be a way to limit the scope though as Elements will need to be embedded into various existing applications and we don't want to be messing things up.

@marcelltoth do you have any tips or ideas for @Fox32?

@philsturgeon
Copy link
Author

Alright just checked an issue in mosaic and it’s gonna happen, just not sure when. Weeks or months not years I expect. Thanks for the feedback @Fox32!

@Fox32
Copy link

Fox32 commented May 4, 2021

Thanks for filling an issue 👍 I totally understand that this is an early state, so my expectations aren't that strong yet.

@marbemac
Copy link
Contributor

@Fox32 I've split the global css reset concern over to a separate issue that we can track - #143.

@Fox32
Copy link

Fox32 commented May 12, 2021

@Fox32 I've split the global css reset concern over to a separate issue that we can track - #143.

Right, that doesn't really belong here, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants