-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch ui-kit to mosaic #115
Comments
FYI there's nothing directly from ui-kit in JSV. The only reason we have it listed is because it's a peer of markdown viewer. This should be blocked by the MDV issue, as it's non-actionable until that's gone. |
Yep! |
I thought about using |
Is mosaic blocking you from installing the lib or is it just a legal/licensing concern? |
A legal/licensing concern. Otherwise it works and looks great - theming was a bit difficult with no direct access to the code or docs. |
@Fox32 thanks for letting me know, easy solve: mosaic now contains the Apache license. We're going to tag a new version that makes that clear on NPM, but here you go: |
Thanks, looking forward to use the package! |
Oh, maybe I was a bit eager with using the new version. Looks like moasic doesn't play nicely when getting integrated into existing applications that aren't based on mosaic. CSS is applied globally and is overwriting our CSS rules. Would be cool if there is a way to limit the scope, but I couldn't have a deeper look into it. |
@Fox32 sorry for the trouble. Just to set expectations, we're not really expecting too many folks to use json-schema-viewer directly at the moment. We've not put the time into documenting it, or any of the usual work we normally do with our supported OSS projects like Elements, Prism, or Spectral. There should be a way to limit the scope though as Elements will need to be embedded into various existing applications and we don't want to be messing things up. @marcelltoth do you have any tips or ideas for @Fox32? |
Alright just checked an issue in mosaic and it’s gonna happen, just not sure when. Weeks or months not years I expect. Thanks for the feedback @Fox32! |
Thanks for filling an issue 👍 I totally understand that this is an early state, so my expectations aren't that strong yet. |
Summary
Switch from ui-kit to equivalent mosaic components.
Tasks
The text was updated successfully, but these errors were encountered: