Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use container with sha value to be sure that the container could not change over time. #3

Open
stbischof opened this issue Oct 10, 2024 · 4 comments

Comments

@stbischof
Copy link

image: ghcr.io/stonemaster/github-actions-runner:main

@stonemaster
Copy link
Owner

Actually I am owning stonemaster/github-actions-runner which right now is updated on a regular basis.
Having an explicit SHA key here would also mean that this repository needs an update every time the upstream container is updated. The way it is now, always the most recent one (implicitly meaning only after a successful build) is used. I still think this is a sane default.

The stonemaster/github-actions-runner repository itself is based on the official GitHub docker container, adding a thin layer of customisation scripts that are needed for this marketplace action.

Let me know your opinion, and why you think an explicit SHA value could be useful 🤔

@stbischof
Copy link
Author

stbischof commented Oct 12, 2024

if i use the setup and is is not linked to the sha, then you could change the contains, this way you can get access to my setup

@stonemaster
Copy link
Owner

What about having an option that defaults to main but would allow you to keep a distinct sha value?
Having to change this every time the base image changes would be tedious for me.

@stbischof
Copy link
Author

would help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants