Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last task is not detected if newline is missing #38

Closed
polinalopit-tomtom opened this issue Jul 31, 2024 · 3 comments
Closed

Last task is not detected if newline is missing #38

polinalopit-tomtom opened this issue Jul 31, 2024 · 3 comments

Comments

@polinalopit-tomtom
Copy link

No description provided.

@stilliard
Copy link
Owner

Hi @polinalopit-tomtom
Please can you give an test/example case of this?
I've tested and created a PR with the following body, no trailing line and it handled the check

### Tests

- [x] A
- [ ] B
- [x] C

image

@polinalopit-tomtom
Copy link
Author

I've posted these three tasks:

  • Add more action items
  • Ensure smth
  • Third task

I've tried to change their order, and it was always the third task that's ignored.
Initially the line with "Third task" was the last line in the comment, and it was only detected if I added a new empty line at the end of the comment

@stilliard
Copy link
Owner

Hi @polinalopit-tomtom
I've created a test PR for this and all 3 show correctly for me:
stilliard/test-repo-ignore#7

could you have a look at the above test PR and see if I've done something different please?
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants