Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow redirect without id_token_hint #60

Open
JimPanse2k19 opened this issue Jan 11, 2023 · 0 comments
Open

Allow redirect without id_token_hint #60

JimPanse2k19 opened this issue Jan 11, 2023 · 0 comments

Comments

@JimPanse2k19
Copy link

I think, the last changes in this implementation

if ($this->validateGteVersion('18.0.0')) {
if (isset($options['access_token']) === true) {
$accessToken = $options['access_token'];
$params['id_token_hint'] = $accessToken->getValues()['id_token'];
$params['post_logout_redirect_uri'] = $params['redirect_uri'];
}
unset($params['redirect_uri']);
}

does not represent the current specs on https://openid.net/specs/openid-connect-rpinitiated-1_0.html where it says, that a id_token parameter is recommended but not mandatory. This current implementation does not allow to have the redirect without a token anymore, which is wrong. The line $params['post_logout_redirect_uri'] = $params['redirect_uri']; should be outside the if statement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant