Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Erigon setup fails #2089

Open
1 task done
stefa2k opened this issue Oct 5, 2024 · 3 comments
Open
1 task done

[Bug]: Erigon setup fails #2089

stefa2k opened this issue Oct 5, 2024 · 3 comments
Assignees
Labels
bug Indicates a bug or unexpected behavior in the application.

Comments

@stefa2k
Copy link
Member

stefa2k commented Oct 5, 2024

Environment

Release

Bug Description

  • Staking setup
  • Mainnet
  • Erigon
  • Nimbus

Erigon tag is set to

image: thorax/erigon:v2.60.8

correct one is

image: thorax/erigon:2.60.8

possibly related to #2052

Launcher Version

2.2.2

Operating System

Mac

Affected Service (if applicable)

Erigon 2.60.8

Logs (if applicable)

No response

Acknowledgment

  • I have checked the existing bugs and confirmed this issue is not already reported.
@stefa2k stefa2k added the bug Indicates a bug or unexpected behavior in the application. label Oct 5, 2024
@daverolo
Copy link
Contributor

daverolo commented Oct 5, 2024

possibly related to #2052

Confirmed

Erigon tag is set to image: thorax/erigon:v2.60.8

Absolutely unclear for me how this could be. The updates.json has the correct tag 2.60.8 and therefore I would expect a working image: thorax/erigon:2.60.8.

Erigon has changed their release repo to erigontech/erigon but the images are still also available on the old thorax/erigon repo.

Problem 1

updates.json correctly sets the tag without v since version 2.60.7 but the image in launcher/src/backend/ethereum-services/ErigonService.js is still thorax/erigon.

To fix this issue we need at least to change the image to erigontech/erigon in ErigonService.js and write playbooks for the Stereum release to adjust existing nodes.

@NeoPlays since this is the same as the SSV image change for mainnet in #2090, it makes probably sense to apply the playbooks patch for both in the same release.

Problem 2

It is unclear how @stefa2k could end up with a v2.60.8 tag while the updates.json tag is correct 2.60.8.

@NeoPlays NeoPlays self-assigned this Oct 5, 2024
@stefa2k
Copy link
Member Author

stefa2k commented Oct 8, 2024

Just had it happen again

@NeoPlays
Copy link
Member

NeoPlays commented Oct 8, 2024

Just had it happen again

The old repo didn't provide multiarch images, which forced us to use special arm tags for erigon. These images tho didn't use the v before the version and then normal ones did until some recent version. So Stereum is adding them if not present. But with the new image we can delete this behaviour completly :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates a bug or unexpected behavior in the application.
Projects
None yet
Development

No branches or pull requests

3 participants