-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Bleach 6.0.0 breaks escape method at mezzanine/utils/html.py #2054
Labels
Comments
This was referenced Apr 10, 2023
Yup, ran into this one too. |
Yep same |
1 task
I just changed line 113 to this and it seems to work so far: |
molokov
added a commit
to molokov/mezzanine
that referenced
this issue
Dec 22, 2023
…el"]; Fixes stephenmcd#2054 due to Bleach version change
Same env same bug, found LordVan's write up here and it fixed it: https://blog.lordvan.com/blog/upgrading-mezzanine-forced-to-due-to-move-to-python310/ Maybe worth a PR? Or is there a good reason we can't |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is there an existing issue for this?
Current Behavior
When trying to save a rich text page you get the following error:
TypeError: unsupported operand type(s) for +: 'frozenset' and 'list'
Expected Behavior
The page should be saved without errors
Steps To Reproduce
Environment
Anything else?
On the latest bleach release, ALLOWED_PROTOCOLS has been changed from list to a frozenset, this is the specific commit: mozilla/bleach@29231a1
This makes this code (https://github.com/stephenmcd/mezzanine/blob/master/mezzanine/utils/html.py#L113) crash:
protocols=ALLOWED_PROTOCOLS + ["tel"]
since lists and frozensets can't be addedDowngrading to bleach==5.0.1 fixes the issue.
The text was updated successfully, but these errors were encountered: