Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Provide configuration via file #1087

Open
atassis opened this issue Aug 12, 2024 · 2 comments
Open

feat: Provide configuration via file #1087

atassis opened this issue Aug 12, 2024 · 2 comments

Comments

@atassis
Copy link
Contributor

atassis commented Aug 12, 2024

It would be nice to provide a configuration for a script from a file, instead command arguments, like eslint, webpack, etc do.

@stephenh
Copy link
Owner

Hi @atassis ; yep, agreed that would make sense. I think originally I anticipated that users would "only use one or two config flags", but I could see that, as things get more complicated, there could be more and more flags...

If you'd like to submit a PR that supports loading the config from a file, like a JSON file or what not, that'd be great!

Not sure if it's worth finding a library that "supports .tsproto.json or .tsproto.ts or .tsproto.yaml" or what not would be worth it, vs something simpler like just assuming the file is always json. Or even just newlines of like:

opt_a=foo
opt_b=bar

Dunno, wdyt?

@atassis
Copy link
Contributor Author

atassis commented Aug 12, 2024

While I was thinking about this issue, I came to a thought that it is better to understand what is going on with options (this is why #1088 was created). I'll first make it obvious about what do options do, and then it'll be easier to see, which way is easier.
Still, if to speculate a bit- it is better to use less packages if available, so it is better to accomplish this task with lesser amount (or 0) of new packages involved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants