-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
you CAN pass publicKey
to Contract Client methods
#1055
Comments
Hello @chadoh i will love to take this up when OD hack begins tomorrow |
I am applying to this issue via OnlyDust platform. My background and how it can be leveragedsoftware engineering background and smart contract developer. How I plan on tackling this issueI would try updating the typescript bindings to accurately document and support the passing of publickey in contract client methods. |
I am applying to this issue via OnlyDust platform. My background and how it can be leveragedi am a blockchain developer and i will like to contribute to this ecosystem. How I plan on tackling this issueTo approach this issue, i will firstly verify the bug by the following:
|
I am applying to this issue via OnlyDust platform. My background and how it can be leveraged@chadoh I am a Frontend and a Blockchain Dev How I plan on tackling this issueThis is the steps i will take to solve the existing bug:
|
@chadoh I'm creating a PR soon, thank you |
Describe the bug
If I pass
publicKey
to a specific method call on a contract client, it tells me that's not supported:But it actually is passed through!
What version are you on?
12.3.0
To Reproduce
Steps to reproduce the behavior:
publicKey
publicKey
to your sender's address. You may need to add a// @ts-ignore
or// @ts-expect-error
before the line!publicKey
you set on the method call is set as the invoker on the call.Expected behavior
We need to update the types to let people know they can do this! It's super handy, allowing you to have static contract clients in the project (as set up in our frontend templates), but still override transaction senders for change methods (which are actually fairly rare in apps, in my experience)
Additional context
We will need to update the types generated in the TS bindings to match, once this is done.
The text was updated successfully, but these errors were encountered: