Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signMessage API returns wrong type according to SEP43 #1634

Open
aristidesstaffieri opened this issue Nov 8, 2024 · 0 comments
Open

signMessage API returns wrong type according to SEP43 #1634

aristidesstaffieri opened this issue Nov 8, 2024 · 0 comments
Assignees

Comments

@aristidesstaffieri
Copy link
Contributor

SEP43 defines the response for signMessage to be

Promise<{
      signedMessage: string;
      signerAddress: string;
    } & error?: Error>,

but our response today is

Promise<{
      signedMessage: Buffer like object;
      signerAddress: string;
    } & error?: Error>,

https://github.com/stellar/stellar-protocol/blob/master/ecosystem/sep-0043.md

This was originally reported by Enrique here #1626

@JakeUrban JakeUrban added bug Something isn't working and removed bug Something isn't working labels Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants