Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fact-checking not correct with centos docker images #89

Closed
stefangweichinger opened this issue Mar 23, 2021 · 1 comment
Closed

fact-checking not correct with centos docker images #89

stefangweichinger opened this issue Mar 23, 2021 · 1 comment

Comments

@stefangweichinger
Copy link
Owner

The fact checking script templates/etc/ansible/facts.d/rclone.fact.j2 (thankfully forked from @drybjed and the debops project) introduced with f281d85 does not return correct facts with the centos7 and centos8 instances, when tested via molecule.

After the first run the binary is installed and in place, then the fact-checker-script should report back ansible_local.rclone.installed = true. This in turn should lead to skipping a reinstallation: it's not needed anymore.

For centos the script returns ansible_local.rclone.installed = false to ansible/molecule, while when logged into the docker container and called from that shell it returns ansible_local.rclone.installed = true.

This doesn't actually break things, it just repeats the installation each time. So far no idea why.

For the other OS tests the new fact-checking-logic seems to work when I look at the molecule logs.

I asked @geerlingguy in geerlingguy/docker-centos7-ansible#13 for any thoughts, as he created the used docker images.

@stefangweichinger
Copy link
Owner Author

I close this now. Centos isn't maintained anymore, we don't run the tests for it anymore ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant