Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Onboarding] Integrate Keycard flows for the new onboarding #17079

Closed
jrainville opened this issue Jan 15, 2025 · 0 comments · Fixed by #17127
Closed

[Onboarding] Integrate Keycard flows for the new onboarding #17079

jrainville opened this issue Jan 15, 2025 · 0 comments · Fixed by #17127
Assignees
@jrainville @igor-sirotin
Labels
core-team E:Desktop Onboarding & Login feature goal:core:P1:onboarding_dropoff
Milestone
2.33.0

Comments

@jrainville
Copy link
Member

Description

Requires #17005

Similar to #17004, hook the UI to the new Go code implemented in the task above using as little nim glue code as possible.

Acceptance criteria

  • The keycard flows of the new onboarding are integrated and all work as expected (see design)
@jrainville jrainville added this to the 2.33.0 Beta milestone Jan 15, 2025
@jrainville jrainville self-assigned this Jan 16, 2025
@jrainville jrainville moved this from Next to In Progress in Status Desktop/Mobile Board Jan 16, 2025
@jrainville jrainville moved this from In Progress to Code Review in Status Desktop/Mobile Board Jan 24, 2025
@jrainville jrainville changed the title [Onboarding] Integrate Keycard flows for thew new onboarding [Onboarding] Integrate Keycard flows for the new onboarding Jan 24, 2025
@jrainville jrainville mentioned this issue Jan 24, 2025
Merged
4 tasks
jrainville added a commit that referenced this issue Jan 29, 2025
@jrainville
feat(onboarding): integrate all keycard flows for the new onboarding
65416c6 
Fixes #17079
jrainville added a commit that referenced this issue Jan 29, 2025
@jrainville
feat(onboarding): integrate all keycard flows for the new onboarding
78e4617 
Fixes #17079
jrainville added a commit that referenced this issue Jan 29, 2025
@jrainville
feat(onboarding): integrate all keycard flows for the new onboarding
ed4446e 
Fixes #17079
igor-sirotin pushed a commit that referenced this issue Feb 2, 2025
@jrainville @igor-sirotin
feat(onboarding): integrate all keycard flows for the new onboarding
0061e2b 
Fixes #17079
@github-project-automation github-project-automation bot moved this from Code Review to Done in Status Desktop/Mobile Board Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrainville jrainville

@igor-sirotin igor-sirotin

Labels
core-team E:Desktop Onboarding & Login feature goal:core:P1:onboarding_dropoff
Projects
Status Desktop/Mobile Board
Status: Done
Milestone
2.33.0
Development

Successfully merging a pull request may close this issue.

Implement the keycard flows for the new onboarding status-im/status-desktop
2 participants
@jrainville @igor-sirotin