Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize autocomplete component #305

Open
KarelJanVanHaute opened this issue Mar 20, 2024 · 2 comments · May be fixed by #331
Open

Optimize autocomplete component #305

KarelJanVanHaute opened this issue Mar 20, 2024 · 2 comments · May be fixed by #331
Assignees

Comments

@KarelJanVanHaute
Copy link
Contributor

Change the dynamicContentObserver to this.

DOMHelper.onDynamicContent(
      document.documentElement,
      "select[data-s-autocomplete]",
      (autocompletes) => {
        Array.from(autocompletes).forEach((ac: HTMLSelectElement, index) => {
          if (!ac.hasAttribute("data-s-autocomplete")) return;
          new Autocomplete(ac, index);
        });
      },
      "data-s-autocomplete"
    );
@KarelJanVanHaute KarelJanVanHaute self-assigned this Mar 20, 2024
@KarelJanVanHaute
Copy link
Contributor Author

KarelJanVanHaute added a commit that referenced this issue Apr 18, 2024
@KarelJanVanHaute KarelJanVanHaute linked a pull request Apr 18, 2024 that will close this issue
@KarelJanVanHaute
Copy link
Contributor Author

And check with the code in MOBSCH

KarelJanVanHaute added a commit that referenced this issue Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants