-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dialog rewrite challenge #285
Labels
Comments
HannahDeWachter
assigned emilyberghen and unassigned carolineboeykens, KarelJanVanHaute, LauraStatik and arnaud-dbu
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is something called the HTMLDialogElement (https://developer.mozilla.org/en-US/docs/Web/API/HTMLDialogElement). This is a native implementation of a dialog. It should be well-supported by now by all browsers. The trickiest is safari 15.4 which is not very old. But old enough?
So the challenge:
Convert all components that use a dialog to use the native HTMLDialogElement. But when it's not supported, load a fallback. Maybe there are polyfills for this? (your google is as good as mine).
Some resources:
https://www.scottohara.me/blog/2019/03/05/open-dialog.html
The text was updated successfully, but these errors were encountered: