-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSG prematurely failing due to changes in spatie/fork package #155
Comments
|
I found out that the |
Maybe it is better to leave this issue open until there is a mitigation for further development? |
globalexport
changed the title
SSG prematurely failing with concurrent workers
SSG prematurely failing due to changes in spatie/fork package
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is this really guaranteed to wait for all closures to finish?
[EDIT] Please see: #155 (comment)
I am in the process of upgrading Statamic v3 to v4. For that reason, I am not 100% sure if the adjusted SSG setup I created in the past is responsible for a possible race condition.
That's why I am testing both, the original SSG command and my custom one.
The original command gives me:
For the sake of simplicity, I am using the new
shouldRejectPage()
method to only allow a small portion of 10 blog pages` urls to be generated on 1 or 2 workers.Using 1 worker always succeeds. Using 2 or more workers rarely succeeds (by chance).
In my own code I am logging everything (method entering, exceptions, etc..), but there is nothing indicating errors during the html generation.
What caught my eye in particular was that the process is interrupted directly after one worker returned from its closure method. There is no
NotGeneratedException
of any worker. It looks like other workers do not get the time to complete their task and return their arrays.Therefore, worker data is missing and the process ends up in
anyTasksFailed
without any useful information.I am thankful for any ideas.
The text was updated successfully, but these errors were encountered: