Skip to content

Package updateEntryUris not compatible with Statche's implementation on composer require #1

@benfurfie

Description

@benfurfie

Describe what the issue is
The package can not be installed when you run the command composer require statamic/eloquent-entries-example.

What should be happening
The package should install as expected when the command is run.

What is happening
A fatal error is occurring: Declaration of Statamic\Eloquent\Entries\CollectionRepository::updateEntryUris($collection) must be compatible with Statamic\Stache\Repositories\CollectionRepository::updateEntryUris(Statamic\Contracts\Entries\Collection $collection, $ids = null)

Steps to replicate

  1. Follow instructions as per the repo.
  2. Run composer require statamic/eloquent-entries-example.
  3. Observe error.

Any other comments
PR to resolve it: #2

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions